Skip to content

Commit 76f001b

Browse files
committed
add factory methods to TestSubscriber
1 parent eccc8c4 commit 76f001b

File tree

2 files changed

+30
-5
lines changed

2 files changed

+30
-5
lines changed

src/main/java/rx/observers/TestSubscriber.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,31 @@ public TestSubscriber() {
9595
this(-1);
9696
}
9797

98+
@Experimental
99+
public static <T> TestSubscriber<T> create() {
100+
return new TestSubscriber<T>();
101+
}
102+
103+
@Experimental
104+
public static <T> TestSubscriber<T> create(long initialRequest) {
105+
return new TestSubscriber<T>(initialRequest);
106+
}
107+
108+
@Experimental
109+
public static <T> TestSubscriber<T> create(Observer<T> delegate, long initialRequest) {
110+
return new TestSubscriber<T>(delegate, initialRequest);
111+
}
112+
113+
@Experimental
114+
public static <T> TestSubscriber<T> create(Subscriber<T> delegate) {
115+
return new TestSubscriber<T>(delegate);
116+
}
117+
118+
@Experimental
119+
public static <T> TestSubscriber<T> create(Observer<T> delegate) {
120+
return new TestSubscriber<T>(delegate);
121+
}
122+
98123
@Override
99124
public void onStart() {
100125
if (initialRequest >= 0) {

src/test/java/rx/internal/operators/OnSubscribeRangeTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public void testRangeWithOverflow5() {
106106
@Test
107107
public void testBackpressureViaRequest() {
108108
OnSubscribeRange o = new OnSubscribeRange(1, RxRingBuffer.SIZE);
109-
TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
109+
TestSubscriber<Integer> ts = TestSubscriber.create();
110110
ts.assertReceivedOnNext(Collections.<Integer> emptyList());
111111
ts.requestMore(1);
112112
o.call(ts);
@@ -127,7 +127,7 @@ public void testNoBackpressure() {
127127
}
128128

129129
OnSubscribeRange o = new OnSubscribeRange(1, list.size());
130-
TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
130+
TestSubscriber<Integer> ts = TestSubscriber.create();
131131
ts.assertReceivedOnNext(Collections.<Integer> emptyList());
132132
ts.requestMore(Long.MAX_VALUE); // infinite
133133
o.call(ts);
@@ -137,7 +137,7 @@ public void testNoBackpressure() {
137137
void testWithBackpressureOneByOne(int start) {
138138
Observable<Integer> source = Observable.range(start, 100);
139139

140-
TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
140+
TestSubscriber<Integer> ts = TestSubscriber.create();
141141
ts.requestMore(1);
142142
source.subscribe(ts);
143143

@@ -152,7 +152,7 @@ void testWithBackpressureOneByOne(int start) {
152152
void testWithBackpressureAllAtOnce(int start) {
153153
Observable<Integer> source = Observable.range(start, 100);
154154

155-
TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
155+
TestSubscriber<Integer> ts = TestSubscriber.create();
156156
ts.requestMore(100);
157157
source.subscribe(ts);
158158

@@ -179,7 +179,7 @@ public void testWithBackpressureAllAtOnce() {
179179
public void testWithBackpressureRequestWayMore() {
180180
Observable<Integer> source = Observable.range(50, 100);
181181

182-
TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
182+
TestSubscriber<Integer> ts = TestSubscriber.create();
183183
ts.requestMore(150);
184184
source.subscribe(ts);
185185

0 commit comments

Comments
 (0)