Add optional bound to onBackpressureBuffer #1899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator takes an optional capacity for the buffer and a callback to be triggered when the buffer fills up.
|
Awesome, I've been wanting this overload. I'm a little swamped right now but will review this and move forward or provide feedback. |
| * @return the source Observable modified to buffer items up to the given capacity. | ||
| * @see <a href="https://github.com/ReactiveX/RxJava/wiki/Backpressure">RxJava wiki: Backpressure</a> | ||
| */ | ||
| public final Observable<T> onBackpressureBuffer(long capacity, Func0<Void> onOverflow) { |
There was a problem hiding this comment.
I suggest using an Action0 here.
There was a problem hiding this comment.
Makes sense. I'll add this as soon as I get some time to fix the broken tests.
benjchristensen
added a commit
to benjchristensen/RxJava
that referenced
this pull request
Dec 2, 2014
benjchristensen
added a commit
to benjchristensen/RxJava
that referenced
this pull request
Dec 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator takes an optional capacity for the buffer and a callback to
be triggered when the buffer fills up.