Skip to content

Fix vararg issues reported in https://github.com/Netflix/RxJava/issues/359 #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 10, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,30 @@ def class ObservableTests {
verify(a, times(1)).received("hello_2");
}

@Test
public void testFromWithIterable() {
def list = [1, 2, 3, 4, 5]
assertEquals(5, Observable.from(list).count().toBlockingObservable().single());
}

@Test
public void testFromWithObjects() {
def list = [1, 2, 3, 4, 5]
// this should now treat these as 2 objects so have a count of 2
assertEquals(2, Observable.from(list, 6).count().toBlockingObservable().single());
}

/**
* Check that two different single arg methods are selected correctly
*/
@Test
public void testStartWith() {
def list = [10, 11, 12, 13, 14]
def startList = [1, 2, 3, 4, 5]
assertEquals(6, Observable.from(list).startWith(0).count().toBlockingObservable().single());
assertEquals(10, Observable.from(list).startWith(startList).count().toBlockingObservable().single());
}

@Test
public void testScriptWithOnNext() {
new TestFactory().getObservable().subscribe({ result -> a.received(result)});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class UnitTestSuite extends JUnitSuite {
}

@Test def testSingleOrDefault {
assertEquals(0, Observable.from[Int]().toBlockingObservable.singleOrDefault(0))
assertEquals(0, Observable.empty[Int]().toBlockingObservable.singleOrDefault(0))
assertEquals(1, Observable.from(1).toBlockingObservable.singleOrDefault(0))
try {
Observable.from(1, 2, 3).toBlockingObservable.singleOrDefault(0)
Expand Down Expand Up @@ -135,8 +135,7 @@ class UnitTestSuite extends JUnitSuite {
@Test def testMerge {
val observable1 = Observable.from(1, 2, 3)
val observable2 = Observable.from(4, 5, 6)
val observableList = List(observable1, observable2).asJava
val merged = Observable.merge(observableList)
val merged = Observable.merge(observable1, observable2)
assertSubscribeReceives(merged)(1, 2, 3, 4, 5, 6)
}

Expand Down Expand Up @@ -232,13 +231,13 @@ class UnitTestSuite extends JUnitSuite {
@Test def testLastOrDefault {
val observable = Observable.from(1, 2, 3, 4)
assertEquals(4, observable.toBlockingObservable.lastOrDefault(5))
assertEquals(5, Observable.from[Int]().toBlockingObservable.lastOrDefault(5))
assertEquals(5, Observable.empty[Int]().toBlockingObservable.lastOrDefault(5))
}

@Test def testLastOrDefaultPredicate {
val observable = Observable.from(1, 2, 3, 4)
assertEquals(3, observable.toBlockingObservable.lastOrDefault(5, isOdd))
assertEquals(5, Observable.from[Int]().toBlockingObservable.lastOrDefault(5, isOdd))
assertEquals(5, Observable.empty[Int]().toBlockingObservable.lastOrDefault(5, isOdd))
}

@Test def testMap {
Expand Down
Loading