2.x: Remove reference counted Disposable public type. #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very specific use case to provide as a first-party type which can always be added back later should there be sufficient demand.
|
Happy to hear arguments for keeping it, but I couldn't come up with any that were convincing enough. |
Current coverage is 69.61% (diff: 100%)@@ 2.x #4388 diff @@
==========================================
Files 449 448 -1
Lines 32004 31983 -21
Methods 0 0
Messages 0 0
Branches 5108 5105 -3
==========================================
- Hits 22306 22266 -40
- Misses 7557 7575 +18
- Partials 2141 2142 +1
|
|
I never saw an use of it; it is a remnant from Rx.NET where it is part of the inner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very specific use case to provide as a first-party type which can always be added back later should there be sufficient demand.