Skip to content

1.x: Remove trailing whitespace #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2016
Merged

1.x: Remove trailing whitespace #4500

merged 1 commit into from
Sep 8, 2016

Conversation

vanniktech
Copy link
Collaborator

Dunno whether this is wanted or not in 1.x. If not just close this PR.

@akarnokd
Copy link
Member

akarnokd commented Sep 8, 2016

I haven't seen IDEs adding them back but only remove them so let's have this to avoid future unneccessary removals from unrelated changes in files.

@vanniktech
Copy link
Collaborator Author

Alright sounds good and then #4123 can be closed

@codecov-io
Copy link

codecov-io commented Sep 8, 2016

Current coverage is 84.34% (diff: 65.38%)

Merging #4500 into 1.x will decrease coverage by 0.08%

@@                1.x      #4500   diff @@
==========================================
  Files           272        272          
  Lines         17647      17647          
  Methods           0          0          
  Messages          0          0          
  Branches       2687       2687          
==========================================
- Hits          14899      14884    -15   
- Misses         1899       1908     +9   
- Partials        849        855     +6   

Powered by Codecov. Last update d86cf19...0cf0c02

@akarnokd akarnokd merged commit ff16f76 into ReactiveX:1.x Sep 8, 2016
@akarnokd akarnokd mentioned this pull request Sep 8, 2016
@vanniktech vanniktech deleted the 1.x_trailing_space branch September 8, 2016 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants