Skip to content

2.x: Add Create test with CancelAble for all types and add more MaybeCreateTest cases #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016
Merged

2.x: Add Create test with CancelAble for all types and add more MaybeCreateTest cases #4540

merged 1 commit into from
Sep 13, 2016

Conversation

vanniktech
Copy link
Collaborator

setCancellable was not tested before.

@akarnokd akarnokd added the Test label Sep 13, 2016
@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 13, 2016
@vanniktech
Copy link
Collaborator Author

Gradle suite > Gradle test > io.reactivex.tck.ObserveOnTckTest. FAILED
java.lang.AssertionError: Illegal concurrent access detected (entering critical section)! Thread[RxSingleScheduler-1,5,main] emited onNext(0) signal, before Thread[Test worker,5,main] finished its onSubscribe() signal.

@akarnokd
Copy link
Member

TCK doesn't seem to like that onSubscribe may trigger emission before it even returns - which is completely legal btw. I'll add a workaround for that in the TCK shortly.

@codecov-io
Copy link

Current coverage is 78.60% (diff: 100%)

Merging #4540 into 2.x will decrease coverage by 0.02%

@@                2.x      #4540   diff @@
==========================================
  Files           530        530          
  Lines         35334      35334          
  Methods           0          0          
  Messages          0          0          
  Branches       5482       5482          
==========================================
- Hits          27782      27773     -9   
- Misses         5576       5584     +8   
- Partials       1976       1977     +1   

Powered by Codecov. Last update c60a21a...61f2347

@akarnokd akarnokd merged commit c030483 into ReactiveX:2.x Sep 13, 2016
@vanniktech vanniktech deleted the 2.x_create_tests branch September 13, 2016 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants