1.x: safeguard against building with 2.* tags #4556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
force-pushed
the
BuildFailSafe
branch
from
9faf69e to
a8f7b48
Compare
Current coverage is 84.42% (diff: 100%)@@ 1.x #4556 diff @@
==========================================
Files 272 272
Lines 17571 17571
Methods 0 0
Messages 0 0
Branches 2683 2683
==========================================
- Hits 14852 14835 -17
- Misses 1862 1873 +11
- Partials 857 863 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a safeguard so that when releasing, mis-tagging the 1.x branch won't build and release
io.reactivex:rxjava:2.*(2.x goes intoio.reactivex.rxjava2:rxjava:2.*).Since I can't try this locally (or can't really try a real tag&release), the PR will get a few commits along the way.