Skip to content

Add extra Maybe iterable Amb tests for overlapped emissions #4567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Add extra Maybe iterable Amb tests for overlapped emissions #4567

merged 1 commit into from
Sep 20, 2016

Conversation

rzsombor
Copy link
Contributor

  • Asserting that downstream will get the results of the first source that began emission, even if multiple sources have overlapped emissions
  • Testing Success and Error paths

- Asserting that downstream will get the results of the first source that began emission, even if multiple sources have overlapped emissions
- Testing Success and Error paths
@rzsombor rzsombor closed this Sep 20, 2016
@rzsombor rzsombor reopened this Sep 20, 2016
@rzsombor
Copy link
Contributor Author

As far as I can see the CI error is coming from a seemingly unrelated test:

io.reactivex.internal.operators.maybe.MaybeUnsubscribeOnTest > normal FAILED
java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at io.reactivex.internal.operators.maybe.MaybeUnsubscribeOnTest.normal(MaybeUnsubscribeOnTest.java:50)

I'm a bit confused here - did I really manage to break this test or is this one known to be flaky?

@akarnokd akarnokd added the Test label Sep 20, 2016
@akarnokd
Copy link
Member

It was a flaky test: the unsubscription may not reach the processor in time the latch unblocks the main thread and thus there appear to be subscribers there.

👍 Thanks for the unit tests.

@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 20, 2016
@akarnokd akarnokd merged commit 20655c3 into ReactiveX:2.x Sep 20, 2016
@rzsombor rzsombor deleted the MaybeAmbOverlapTests branch September 20, 2016 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants