Skip to content

1.x: remove semicolon that Eclipse thinks is compile error #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2017

Conversation

davidmoten
Copy link
Collaborator

as per title, gradle build works fine but Eclipse doesn't like it.

@codecov
Copy link

codecov bot commented May 18, 2017

Codecov Report

Merging #5353 into 1.x will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x    #5353      +/-   ##
============================================
- Coverage     84.36%   84.29%   -0.08%     
+ Complexity     2888     2880       -8     
============================================
  Files           291      291              
  Lines         18129    18129              
  Branches       2479     2479              
============================================
- Hits          15294    15281      -13     
- Misses         1965     1974       +9     
- Partials        870      874       +4
Impacted Files Coverage Δ Complexity Δ
.../java/rx/internal/util/unsafe/MpscLinkedQueue.java 75.75% <0%> (-12.13%) 9% <0%> (-1%)
...nal/util/atomic/SpscUnboundedAtomicArrayQueue.java 75.21% <0%> (-8.55%) 30% <0%> (-4%)
...in/java/rx/internal/schedulers/SleepingAction.java 55.55% <0%> (-5.56%) 2% <0%> (-1%)
...n/java/rx/subscriptions/CompositeSubscription.java 74.02% <0%> (-2.6%) 23% <0%> (-1%)
.../java/rx/internal/operators/BackpressureUtils.java 70.45% <0%> (-2.28%) 28% <0%> (-1%)
...in/java/rx/internal/operators/OperatorGroupBy.java 90.81% <0%> (-0.71%) 5% <0%> (ø)
...n/java/rx/subjects/SubjectSubscriptionManager.java 81.42% <0%> (+0.71%) 15% <0%> (ø) ⬇️
...ain/java/rx/internal/operators/OnSubscribeAmb.java 84.17% <0%> (+5.03%) 13% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c0cd0...37349cf. Read the comment docs.

@akarnokd akarnokd added this to the 1.4 milestone May 18, 2017
@akarnokd akarnokd merged commit 433b099 into ReactiveX:1.x May 18, 2017
@davidmoten davidmoten deleted the remove-semicolon branch May 18, 2017 07:53
@@ -14,7 +14,7 @@
* limitations under the License.
*/
package rx.internal.operators;
;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants