Skip to content

2.x: Replace duplicate calling method setAccessible on the same object in FunctionsTest class. #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

youngam
Copy link
Contributor

@youngam youngam commented Jun 30, 2017

I would like to add unit tests to my project and decided to watch tests in this repository. During reviewing testing class FunctionsTest I watch duplicated calling method setAccessible(true) at the same object.

@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #5454 into 2.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5454      +/-   ##
============================================
- Coverage     96.09%   96.06%   -0.04%     
  Complexity     5797     5797              
============================================
  Files           631      631              
  Lines         41306    41306              
  Branches       5745     5745              
============================================
- Hits          39694    39680      -14     
- Misses          624      640      +16     
+ Partials        988      986       -2
Impacted Files Coverage Δ Complexity Δ
...rnal/subscriptions/ArrayCompositeSubscription.java 93.33% <0%> (-6.67%) 17% <0%> (-1%)
.../java/io/reactivex/subjects/SerializedSubject.java 89.47% <0%> (-6.32%) 26% <0%> (-1%)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 87.61% <0%> (-5.76%) 62% <0%> (ø)
...rnal/subscribers/SinglePostCompleteSubscriber.java 94.87% <0%> (-5.13%) 14% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...reactivex/internal/operators/maybe/MaybeUsing.java 95.95% <0%> (-4.05%) 4% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
...ex/internal/operators/maybe/MaybeTimeoutMaybe.java 95.58% <0%> (-2.95%) 2% <0%> (ø)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8f008...b127fc4. Read the comment docs.

@youngam youngam changed the title Replace duplicate calling method setAccessible on the same object in FunctionsTest class. 2.x: Replace duplicate calling method setAccessible on the same object in FunctionsTest class. Jul 1, 2017
@akarnokd akarnokd added this to the 2.2 milestone Jul 3, 2017
@akarnokd akarnokd merged commit 3480eb9 into ReactiveX:2.x Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants