Skip to content

Refactoring SingleSchedulerTest #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pwittchen
Copy link

@pwittchen pwittchen commented Jul 4, 2017

Hi,

I refactored SingleSchedulerTest. Now it extends AbstractSchedulerTests, so redundant tests (with duplicated code) could be removed in favor of abstract tests. Now, thanks to the abstract test class, SingleScheduler has 21 unit tests instead of just 7. This approach is consistent with the test classes for other Schedulers.

Regards,
Piotr

…s, so redundant tests could be removed in favor of abstract tests.
@codecov
Copy link

codecov bot commented Jul 4, 2017

Codecov Report

Merging #5462 into 2.x will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5462      +/-   ##
============================================
+ Coverage     95.98%   96.07%   +0.09%     
- Complexity     5796     5804       +8     
============================================
  Files           631      631              
  Lines         41306    41306              
  Branches       5745     5745              
============================================
+ Hits          39647    39686      +39     
+ Misses          648      635      -13     
+ Partials       1011      985      -26
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/flowable/FlowableSubscribeOn.java 91.52% <0%> (-6.78%) 2% <0%> (ø)
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 93.87% <0%> (-6.13%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 84.89% <0%> (-5.73%) 56% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 90.57% <0%> (-4.35%) 2% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...reactivex/internal/operators/maybe/MaybeUsing.java 93.93% <0%> (-4.05%) 4% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-3.39%) 10% <0%> (-1%)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1327982...468c1b8. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Jul 4, 2017
@akarnokd akarnokd merged commit 08be741 into ReactiveX:2.x Jul 5, 2017
@pwittchen pwittchen deleted the refactoring-single-scheduler-test branch July 5, 2017 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants