Skip to content

Commit 4fe3cd8

Browse files
deregister: Robustify check, just in case C++ recycles memory with unique_ptr
1 parent 244b1aa commit 4fe3cd8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/pybind11/detail/class.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ inline bool deregister_instance_impl(void *ptr, instance *self) {
222222
auto &registered_instances = get_internals().registered_instances;
223223
auto range = registered_instances.equal_range(ptr);
224224
for (auto it = range.first; it != range.second; ++it) {
225-
if (Py_TYPE(self) == Py_TYPE(it->second)) {
225+
if (self == it->second && Py_TYPE(self) == Py_TYPE(it->second)) {
226226
registered_instances.erase(it);
227227
return true;
228228
}

0 commit comments

Comments
 (0)