Skip to content

Commit 001a3df

Browse files
lategoodbyegregkh
authored andcommitted
staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT
checkpatch.pl complains ERROR: Macros with complex values should be enclosed in parentheses +#define VCHIQ_MSG_SRCPORT(msgid) \ + (unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff) Signed-off-by: Stefan Wahren <[email protected]> Reviewed-by: Umang Jain <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent aab6433 commit 001a3df

File tree

1 file changed

+1
-1
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+1
-1
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
(((type) << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0))
4444
#define VCHIQ_MSG_TYPE(msgid) ((unsigned int)(msgid) >> TYPE_SHIFT)
4545
#define VCHIQ_MSG_SRCPORT(msgid) \
46-
(unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff)
46+
((unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff))
4747
#define VCHIQ_MSG_DSTPORT(msgid) \
4848
((unsigned short)(msgid) & 0xfff)
4949

0 commit comments

Comments
 (0)