Skip to content

Commit 025a6f7

Browse files
jhovoldvinodkoul
authored andcommitted
phy: qcom: qmp-combo: fix VCO div offset on v5_5nm and v6
Commit 5abed58 ("phy: qcom: qmp-combo: Fix VCO div offset on v3") fixed a regression introduced in 6.5 by making sure that the correct offset is used for the DP_PHY_VCO_DIV register on v3 hardware. Unfortunately, that fix instead broke DisplayPort on v5_5nm and v6 hardware as it failed to add the corresponding offsets also to those register tables. Fixes: 815891e ("phy: qcom-qmp-combo: Introduce orientation variable") Fixes: 5abed58 ("phy: qcom: qmp-combo: Fix VCO div offset on v3") Cc: [email protected] # 6.5: 5abed58 Cc: Stephen Boyd <[email protected]> Cc: Abhinav Kumar <[email protected]> Cc: Dmitry Baryshkov <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Stephen Boyd <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent e1c9216 commit 025a6f7

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ static const unsigned int qmp_v5_5nm_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = {
153153
[QPHY_COM_BIAS_EN_CLKBUFLR_EN] = QSERDES_V5_COM_BIAS_EN_CLKBUFLR_EN,
154154

155155
[QPHY_DP_PHY_STATUS] = QSERDES_V5_DP_PHY_STATUS,
156+
[QPHY_DP_PHY_VCO_DIV] = QSERDES_V5_DP_PHY_VCO_DIV,
156157

157158
[QPHY_TX_TX_POL_INV] = QSERDES_V5_5NM_TX_TX_POL_INV,
158159
[QPHY_TX_TX_DRV_LVL] = QSERDES_V5_5NM_TX_TX_DRV_LVL,
@@ -177,6 +178,7 @@ static const unsigned int qmp_v6_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = {
177178
[QPHY_COM_BIAS_EN_CLKBUFLR_EN] = QSERDES_V6_COM_PLL_BIAS_EN_CLK_BUFLR_EN,
178179

179180
[QPHY_DP_PHY_STATUS] = QSERDES_V6_DP_PHY_STATUS,
181+
[QPHY_DP_PHY_VCO_DIV] = QSERDES_V6_DP_PHY_VCO_DIV,
180182

181183
[QPHY_TX_TX_POL_INV] = QSERDES_V6_TX_TX_POL_INV,
182184
[QPHY_TX_TX_DRV_LVL] = QSERDES_V6_TX_TX_DRV_LVL,

drivers/phy/qualcomm/phy-qcom-qmp-dp-phy-v5.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#define QCOM_PHY_QMP_DP_PHY_V5_H_
88

99
/* Only for QMP V5 PHY - DP PHY registers */
10+
#define QSERDES_V5_DP_PHY_VCO_DIV 0x070
1011
#define QSERDES_V5_DP_PHY_AUX_INTERRUPT_STATUS 0x0d8
1112
#define QSERDES_V5_DP_PHY_STATUS 0x0dc
1213

drivers/phy/qualcomm/phy-qcom-qmp-dp-phy-v6.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#define QCOM_PHY_QMP_DP_PHY_V6_H_
88

99
/* Only for QMP V6 PHY - DP PHY registers */
10+
#define QSERDES_V6_DP_PHY_VCO_DIV 0x070
1011
#define QSERDES_V6_DP_PHY_AUX_INTERRUPT_STATUS 0x0e0
1112
#define QSERDES_V6_DP_PHY_STATUS 0x0e4
1213

0 commit comments

Comments
 (0)