Skip to content

Commit 02f2f76

Browse files
committed
tracing: Allow irq/preempt tracers to be used by instances
The irqsoff, preemptoff and preemptirqsoff tracers can now be used by instances. But they may only be used by one instance at a time (including the top level directory). This allows multiple tracers to run while the irqsoff (and friends) tracer is running simultaneously. Signed-off-by: Steven Rostedt <[email protected]>
1 parent 65daaca commit 02f2f76

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

kernel/trace/trace_irqsoff.c

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,13 @@ static void stop_irqsoff_tracer(struct trace_array *tr, int graph)
597597
unregister_irqsoff_function(tr, graph);
598598
}
599599

600-
static void __irqsoff_tracer_init(struct trace_array *tr)
600+
static bool irqsoff_busy;
601+
602+
static int __irqsoff_tracer_init(struct trace_array *tr)
601603
{
604+
if (irqsoff_busy)
605+
return -EBUSY;
606+
602607
save_flags = trace_flags;
603608

604609
/* non overwrite screws up the latency tracers */
@@ -617,6 +622,9 @@ static void __irqsoff_tracer_init(struct trace_array *tr)
617622
if (start_irqsoff_tracer(tr, (tr->flags & TRACE_ARRAY_FL_GLOBAL &&
618623
is_graph())))
619624
printk(KERN_ERR "failed to start irqsoff tracer\n");
625+
626+
irqsoff_busy = true;
627+
return 0;
620628
}
621629

622630
static void irqsoff_tracer_reset(struct trace_array *tr)
@@ -629,6 +637,8 @@ static void irqsoff_tracer_reset(struct trace_array *tr)
629637
set_tracer_flag(tr, TRACE_ITER_LATENCY_FMT, lat_flag);
630638
set_tracer_flag(tr, TRACE_ITER_OVERWRITE, overwrite_flag);
631639
ftrace_reset_array_ops(tr);
640+
641+
irqsoff_busy = false;
632642
}
633643

634644
static void irqsoff_tracer_start(struct trace_array *tr)
@@ -646,8 +656,7 @@ static int irqsoff_tracer_init(struct trace_array *tr)
646656
{
647657
trace_type = TRACER_IRQS_OFF;
648658

649-
__irqsoff_tracer_init(tr);
650-
return 0;
659+
return __irqsoff_tracer_init(tr);
651660
}
652661
static struct tracer irqsoff_tracer __read_mostly =
653662
{
@@ -667,6 +676,7 @@ static struct tracer irqsoff_tracer __read_mostly =
667676
#endif
668677
.open = irqsoff_trace_open,
669678
.close = irqsoff_trace_close,
679+
.allow_instances = true,
670680
.use_max_tr = true,
671681
};
672682
# define register_irqsoff(trace) register_tracer(&trace)
@@ -679,8 +689,7 @@ static int preemptoff_tracer_init(struct trace_array *tr)
679689
{
680690
trace_type = TRACER_PREEMPT_OFF;
681691

682-
__irqsoff_tracer_init(tr);
683-
return 0;
692+
return __irqsoff_tracer_init(tr);
684693
}
685694

686695
static struct tracer preemptoff_tracer __read_mostly =
@@ -701,6 +710,7 @@ static struct tracer preemptoff_tracer __read_mostly =
701710
#endif
702711
.open = irqsoff_trace_open,
703712
.close = irqsoff_trace_close,
713+
.allow_instances = true,
704714
.use_max_tr = true,
705715
};
706716
# define register_preemptoff(trace) register_tracer(&trace)
@@ -715,8 +725,7 @@ static int preemptirqsoff_tracer_init(struct trace_array *tr)
715725
{
716726
trace_type = TRACER_IRQS_OFF | TRACER_PREEMPT_OFF;
717727

718-
__irqsoff_tracer_init(tr);
719-
return 0;
728+
return __irqsoff_tracer_init(tr);
720729
}
721730

722731
static struct tracer preemptirqsoff_tracer __read_mostly =
@@ -737,6 +746,7 @@ static struct tracer preemptirqsoff_tracer __read_mostly =
737746
#endif
738747
.open = irqsoff_trace_open,
739748
.close = irqsoff_trace_close,
749+
.allow_instances = true,
740750
.use_max_tr = true,
741751
};
742752

0 commit comments

Comments
 (0)