Skip to content

Commit 03fbdb1

Browse files
rubiniRussell King
authored andcommitted
[ARM] 5519/1: amba probe: pass "struct amba_id *" instead of void *
The second argument of the probe method points to the amba_id structure, so it's better passed with the correct type. None of the current in-tree drivers uses the pointer, so they have only been checked for a clean compile. Change suggested by Russell King. Signed-off-by: Alessandro Rubini <[email protected]> Signed-off-by: Russell King <[email protected]>
1 parent a93ea9b commit 03fbdb1

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

drivers/input/serio/ambakmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ static void amba_kmi_close(struct serio *io)
107107
clk_disable(kmi->clk);
108108
}
109109

110-
static int amba_kmi_probe(struct amba_device *dev, void *id)
110+
static int amba_kmi_probe(struct amba_device *dev, struct amba_id *id)
111111
{
112112
struct amba_kmi_port *kmi;
113113
struct serio *io;

drivers/mmc/host/mmci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ static void mmci_check_status(unsigned long data)
490490
mod_timer(&host->timer, jiffies + HZ);
491491
}
492492

493-
static int __devinit mmci_probe(struct amba_device *dev, void *id)
493+
static int __devinit mmci_probe(struct amba_device *dev, struct amba_id *id)
494494
{
495495
struct mmc_platform_data *plat = dev->dev.platform_data;
496496
struct mmci_host *host;

drivers/rtc/rtc-pl030.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static const struct rtc_class_ops pl030_ops = {
102102
.set_alarm = pl030_set_alarm,
103103
};
104104

105-
static int pl030_probe(struct amba_device *dev, void *id)
105+
static int pl030_probe(struct amba_device *dev, struct amba_id *id)
106106
{
107107
struct pl030_rtc *rtc;
108108
int ret;

drivers/rtc/rtc-pl031.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ static int pl031_remove(struct amba_device *adev)
127127
return 0;
128128
}
129129

130-
static int pl031_probe(struct amba_device *adev, void *id)
130+
static int pl031_probe(struct amba_device *adev, struct amba_id *id)
131131
{
132132
int ret;
133133
struct pl031_local *ldata;

drivers/serial/amba-pl010.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ static struct uart_driver amba_reg = {
665665
.cons = AMBA_CONSOLE,
666666
};
667667

668-
static int pl010_probe(struct amba_device *dev, void *id)
668+
static int pl010_probe(struct amba_device *dev, struct amba_id *id)
669669
{
670670
struct uart_amba_port *uap;
671671
void __iomem *base;

drivers/serial/amba-pl011.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ static struct uart_driver amba_reg = {
729729
.cons = AMBA_CONSOLE,
730730
};
731731

732-
static int pl011_probe(struct amba_device *dev, void *id)
732+
static int pl011_probe(struct amba_device *dev, struct amba_id *id)
733733
{
734734
struct uart_amba_port *uap;
735735
void __iomem *base;

drivers/video/amba-clcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ static int clcdfb_register(struct clcd_fb *fb)
437437
return ret;
438438
}
439439

440-
static int clcdfb_probe(struct amba_device *dev, void *id)
440+
static int clcdfb_probe(struct amba_device *dev, struct amba_id *id)
441441
{
442442
struct clcd_board *board = dev->dev.platform_data;
443443
struct clcd_fb *fb;

include/linux/amba/bus.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ struct amba_id {
2828

2929
struct amba_driver {
3030
struct device_driver drv;
31-
int (*probe)(struct amba_device *, void *);
31+
int (*probe)(struct amba_device *, struct amba_id *);
3232
int (*remove)(struct amba_device *);
3333
void (*shutdown)(struct amba_device *);
3434
int (*suspend)(struct amba_device *, pm_message_t);

sound/arm/aaci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,7 @@ static unsigned int __devinit aaci_size_fifo(struct aaci *aaci)
10741074
return i;
10751075
}
10761076

1077-
static int __devinit aaci_probe(struct amba_device *dev, void *id)
1077+
static int __devinit aaci_probe(struct amba_device *dev, struct amba_id *id)
10781078
{
10791079
struct aaci *aaci;
10801080
int ret, i;

0 commit comments

Comments
 (0)