Skip to content

Commit 056bce6

Browse files
Pavan Chebbikuba-moo
authored andcommitted
bnxt_en: Make PTP TX timestamp HWRM query silent
In a busy network, especially with flow control enabled, we may experience timestamp query failures fairly regularly. After a while, dmesg may be flooded with timestamp query failure error messages. Silence the error message from the low level hwrm function that sends the firmware message. Change netdev_err() to netdev_WARN_ONCE() if this FW call ever fails. Signed-off-by: Pavan Chebbi <[email protected]> Signed-off-by: Michael Chan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 84793a4 commit 056bce6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ static int bnxt_hwrm_port_ts_query(struct bnxt *bp, u32 flags, u64 *ts)
129129
}
130130
resp = hwrm_req_hold(bp, req);
131131

132-
rc = hwrm_req_send(bp, req);
132+
rc = hwrm_req_send_silent(bp, req);
133133
if (!rc)
134134
*ts = le64_to_cpu(resp->ptp_msg_ts);
135135
hwrm_req_drop(bp, req);
@@ -684,8 +684,8 @@ static void bnxt_stamp_tx_skb(struct bnxt *bp, struct sk_buff *skb)
684684
timestamp.hwtstamp = ns_to_ktime(ns);
685685
skb_tstamp_tx(ptp->tx_skb, &timestamp);
686686
} else {
687-
netdev_err(bp->dev, "TS query for TX timer failed rc = %x\n",
688-
rc);
687+
netdev_WARN_ONCE(bp->dev,
688+
"TS query for TX timer failed rc = %x\n", rc);
689689
}
690690

691691
dev_kfree_skb_any(ptp->tx_skb);

0 commit comments

Comments
 (0)