Skip to content

Commit 08b7cf1

Browse files
wellslutwlinusw
authored andcommitted
pinctrl: Fix an error in pin-function table of SP7021
The first valid item of pin-function table should start from the third item. The first two items, due to historical and compatible reasons, should be dummy items. The two dummy items were removed accidentally in initial submission. This fix adds them back. Signed-off-by: Wells Lu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 8795092 commit 08b7cf1

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/pinctrl/sunplus/sppctl_sp7021.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,15 @@ static const struct sppctl_grp sp7021grps_prbp[] = {
419419
EGRP("PROBE_PORT2", 2, pins_prp2),
420420
};
421421

422+
/*
423+
* Due to compatible reason, the first valid item should start at the third
424+
* position of the array. Please keep the first two items of the table
425+
* no use (dummy).
426+
*/
422427
const struct sppctl_func sppctl_list_funcs[] = {
428+
FNCN("", pinmux_type_fpmx, 0x00, 0, 0),
429+
FNCN("", pinmux_type_fpmx, 0x00, 0, 0),
430+
423431
FNCN("L2SW_CLK_OUT", pinmux_type_fpmx, 0x00, 0, 7),
424432
FNCN("L2SW_MAC_SMI_MDC", pinmux_type_fpmx, 0x00, 8, 7),
425433
FNCN("L2SW_LED_FLASH0", pinmux_type_fpmx, 0x01, 0, 7),

0 commit comments

Comments
 (0)