Skip to content

Commit 1224b21

Browse files
hormskuba-moo
authored andcommitted
pldmfw: Select CRC32 when PLDMFW is selected
pldmfw calls crc32 code and depends on it being enabled, else there is a link error as follows. So PLDMFW should select CRC32. lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image': pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base' This problem was introduced by commit b826562 ("Add pldmfw library for PLDM firmware update"). It manifests as of commit d69ea41 ("ice: implement device flash update via devlink"). And is more likely to occur as of commit 9ad1917 ("lib/crc: remove unnecessary prompt for CONFIG_CRC32 and drop 'default y'"). Found by chance while exercising builds based on tinyconfig. Fixes: b826562 ("Add pldmfw library for PLDM firmware update") Signed-off-by: Simon Horman <[email protected]> Reviewed-by: Jacob Keller <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5466491 commit 1224b21

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -716,6 +716,7 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
716716

717717
config PLDMFW
718718
bool
719+
select CRC32
719720
default n
720721

721722
config ASN1_ENCODER

0 commit comments

Comments
 (0)