Skip to content

Commit 18b429e

Browse files
pprindevilledavem330
authored andcommitted
atm/solos-pci: Don't include frame pseudo-header on transmit hex-dump
Omit pkt_hdr preamble when dumping transmitted packet as hex-dump; we can pull this up because the frame has already been sent, and dumping it is the last thing we do with it before freeing it. Also include the size, vpi, and vci in the debug as is done on receive. Use "port" consistently instead of "device" intermittently. Signed-off-by: Philip Prindeville <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1e19e65 commit 18b429e

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

drivers/atm/solos-pci.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ void solos_bh(unsigned long card_arg)
697697
size);
698698
}
699699
if (atmdebug) {
700-
dev_info(&card->dev->dev, "Received: device %d\n", port);
700+
dev_info(&card->dev->dev, "Received: port %d\n", port);
701701
dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
702702
size, le16_to_cpu(header->vpi),
703703
le16_to_cpu(header->vci));
@@ -1018,8 +1018,15 @@ static uint32_t fpga_tx(struct solos_card *card)
10181018

10191019
/* Clean up and free oldskb now it's gone */
10201020
if (atmdebug) {
1021+
struct pkt_hdr *header = (void *)oldskb->data;
1022+
int size = le16_to_cpu(header->size);
1023+
1024+
skb_pull(oldskb, sizeof(*header));
10211025
dev_info(&card->dev->dev, "Transmitted: port %d\n",
10221026
port);
1027+
dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
1028+
size, le16_to_cpu(header->vpi),
1029+
le16_to_cpu(header->vci));
10231030
print_buffer(oldskb);
10241031
}
10251032

0 commit comments

Comments
 (0)