Skip to content

Commit 1dc9f1a

Browse files
Wang Qinggregkh
authored andcommitted
arch_topology: Do not set llc_sibling if llc_id is invalid
When ACPI is not enabled, cpuid_topo->llc_id = cpu_topo->llc_id = -1, which will set llc_sibling 0xff(...), this is misleading. Don't set llc_sibling(default 0) if we don't know the cache topology. Reviewed-by: Sudeep Holla <[email protected]> Signed-off-by: Wang Qing <[email protected]> Fixes: 37c3ec2 ("arm64: topology: divorce MC scheduling domain from core_siblings") Cc: stable <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent db1e594 commit 1dc9f1a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/arch_topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ void update_siblings_masks(unsigned int cpuid)
693693
for_each_online_cpu(cpu) {
694694
cpu_topo = &cpu_topology[cpu];
695695

696-
if (cpuid_topo->llc_id == cpu_topo->llc_id) {
696+
if (cpu_topo->llc_id != -1 && cpuid_topo->llc_id == cpu_topo->llc_id) {
697697
cpumask_set_cpu(cpu, &cpuid_topo->llc_sibling);
698698
cpumask_set_cpu(cpuid, &cpu_topo->llc_sibling);
699699
}

0 commit comments

Comments
 (0)