Skip to content

Commit 201a088

Browse files
rddunlapkuba-moo
authored andcommitted
net: llc: fix kernel-doc notation warnings
Use the corrent function parameter name or format to prevent kernel-doc warnings. Add 2 function parameter descriptions to prevent kernel-doc warnings. llc_pdu.h:278: warning: Function parameter or member 'da' not described in 'llc_pdu_decode_da' llc_pdu.h:278: warning: Excess function parameter 'sa' description in 'llc_pdu_decode_da' llc_pdu.h:330: warning: Function parameter or member 'skb' not described in 'llc_pdu_init_as_test_cmd' llc_pdu.h:379: warning: Function parameter or member 'svcs_supported' not described in 'llc_pdu_init_as_xid_cmd' llc_pdu.h:379: warning: Function parameter or member 'rx_window' not described in 'llc_pdu_init_as_xid_cmd' Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Randy Dunlap <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent d20909a commit 201a088

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

include/net/llc_pdu.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ static inline void llc_pdu_decode_sa(struct sk_buff *skb, u8 *sa)
269269
/**
270270
* llc_pdu_decode_da - extracts dest address of input frame
271271
* @skb: input skb that destination address must be extracted from it
272-
* @sa: pointer to destination address (6 byte array).
272+
* @da: pointer to destination address (6 byte array).
273273
*
274274
* This function extracts destination address(MAC) of input frame.
275275
*/
@@ -321,7 +321,7 @@ static inline void llc_pdu_init_as_ui_cmd(struct sk_buff *skb)
321321

322322
/**
323323
* llc_pdu_init_as_test_cmd - sets PDU as TEST
324-
* @skb - Address of the skb to build
324+
* @skb: Address of the skb to build
325325
*
326326
* Sets a PDU as TEST
327327
*/
@@ -369,6 +369,8 @@ struct llc_xid_info {
369369
/**
370370
* llc_pdu_init_as_xid_cmd - sets bytes 3, 4 & 5 of LLC header as XID
371371
* @skb: input skb that header must be set into it.
372+
* @svcs_supported: The class of the LLC (I or II)
373+
* @rx_window: The size of the receive window of the LLC
372374
*
373375
* This function sets third,fourth,fifth and sixth bytes of LLC header as
374376
* a XID PDU.

0 commit comments

Comments
 (0)