Skip to content

Commit 21608a2

Browse files
mosheshemesh2Saeed Mahameed
authored andcommitted
Revert "net/mlx5: Remove "recovery" arg from mlx5_load_one() function"
This reverts commit 5977ac3. Revert this patch as we need the "recovery" arg back in mlx5_load_one() function. This arg will be used in the next patch for using recovery timeout during sync reset flow. Signed-off-by: Moshe Shemesh <[email protected]> Reviewed-by: Maher Sanalla <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 0a6b069 commit 21608a2

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ static void mlx5_fw_reset_complete_reload(struct mlx5_core_dev *dev)
167167
if (mlx5_health_wait_pci_up(dev))
168168
mlx5_core_err(dev, "reset reload flow aborted, PCI reads still not working\n");
169169
else
170-
mlx5_load_one(dev);
170+
mlx5_load_one(dev, false);
171171
devlink_remote_reload_actions_performed(priv_to_devlink(dev), 0,
172172
BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
173173
BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE));

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,13 +1509,13 @@ int mlx5_load_one_devl_locked(struct mlx5_core_dev *dev, bool recovery)
15091509
return err;
15101510
}
15111511

1512-
int mlx5_load_one(struct mlx5_core_dev *dev)
1512+
int mlx5_load_one(struct mlx5_core_dev *dev, bool recovery)
15131513
{
15141514
struct devlink *devlink = priv_to_devlink(dev);
15151515
int ret;
15161516

15171517
devl_lock(devlink);
1518-
ret = mlx5_load_one_devl_locked(dev, false);
1518+
ret = mlx5_load_one_devl_locked(dev, recovery);
15191519
devl_unlock(devlink);
15201520
return ret;
15211521
}
@@ -1912,7 +1912,8 @@ static void mlx5_pci_resume(struct pci_dev *pdev)
19121912

19131913
mlx5_pci_trace(dev, "Enter, loading driver..\n");
19141914

1915-
err = mlx5_load_one(dev);
1915+
err = mlx5_load_one(dev, false);
1916+
19161917
if (!err)
19171918
devlink_health_reporter_state_update(dev->priv.health.fw_fatal_reporter,
19181919
DEVLINK_HEALTH_REPORTER_STATE_HEALTHY);
@@ -2003,7 +2004,7 @@ static int mlx5_resume(struct pci_dev *pdev)
20032004
{
20042005
struct mlx5_core_dev *dev = pci_get_drvdata(pdev);
20052006

2006-
return mlx5_load_one(dev);
2007+
return mlx5_load_one(dev, false);
20072008
}
20082009

20092010
static const struct pci_device_id mlx5_core_pci_table[] = {

drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ int mlx5_init_one(struct mlx5_core_dev *dev);
321321
void mlx5_uninit_one(struct mlx5_core_dev *dev);
322322
void mlx5_unload_one(struct mlx5_core_dev *dev, bool suspend);
323323
void mlx5_unload_one_devl_locked(struct mlx5_core_dev *dev, bool suspend);
324-
int mlx5_load_one(struct mlx5_core_dev *dev);
324+
int mlx5_load_one(struct mlx5_core_dev *dev, bool recovery);
325325
int mlx5_load_one_devl_locked(struct mlx5_core_dev *dev, bool recovery);
326326

327327
int mlx5_vport_set_other_func_cap(struct mlx5_core_dev *dev, const void *hca_cap, u16 function_id,

0 commit comments

Comments
 (0)