Skip to content

Commit 2900bcb

Browse files
valschneiderrostedt
authored andcommitted
tracing/filters: Change parse_pred() cpulist ternary into an if block
Review comments noted that an if block would be clearer than a ternary, so swap it out. No change in behaviour intended Link: https://lkml.kernel.org/r/[email protected] Cc: Masami Hiramatsu <[email protected]> Signed-off-by: Valentin Schneider <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 1caf7ad commit 2900bcb

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

kernel/trace/trace_events_filter.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1782,13 +1782,17 @@ static int parse_pred(const char *str, void *data,
17821782
FILTER_PRED_FN_CPUMASK;
17831783
} else if (field->filter_type == FILTER_CPU) {
17841784
if (single) {
1785-
pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
1785+
if (pred->op == OP_BAND)
1786+
pred->op = OP_EQ;
1787+
17861788
pred->fn_num = FILTER_PRED_FN_CPU;
17871789
} else {
17881790
pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK;
17891791
}
17901792
} else if (single) {
1791-
pred->op = pred->op == OP_BAND ? OP_EQ : pred->op;
1793+
if (pred->op == OP_BAND)
1794+
pred->op = OP_EQ;
1795+
17921796
pred->fn_num = select_comparison_fn(pred->op, field->size, false);
17931797
if (pred->op == OP_NE)
17941798
pred->not = 1;

0 commit comments

Comments
 (0)