Skip to content

Commit 2a303f1

Browse files
author
Saeed Mahameed
committed
net/mlx5e: IPoIB, use separate stats groups
Don't copy all of the stats groups used for mlx5e ethernet NIC profile, have a separate stats groups for IPoIB with the set of the needed stats only. Signed-off-by: Saeed Mahameed <[email protected]>
1 parent f0ff8e8 commit 2a303f1

File tree

3 files changed

+51
-15
lines changed

3 files changed

+51
-15
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,19 +1700,19 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STATS(channels)
17001700

17011701
static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(channels) { return; }
17021702

1703-
static MLX5E_DEFINE_STATS_GRP(sw, 0);
1704-
static MLX5E_DEFINE_STATS_GRP(qcnt, MLX5E_NDO_UPDATE_STATS);
1705-
static MLX5E_DEFINE_STATS_GRP(vnic_env, 0);
1706-
static MLX5E_DEFINE_STATS_GRP(vport, MLX5E_NDO_UPDATE_STATS);
1707-
static MLX5E_DEFINE_STATS_GRP(802_3, MLX5E_NDO_UPDATE_STATS);
1708-
static MLX5E_DEFINE_STATS_GRP(2863, 0);
1709-
static MLX5E_DEFINE_STATS_GRP(2819, 0);
1710-
static MLX5E_DEFINE_STATS_GRP(phy, 0);
1711-
static MLX5E_DEFINE_STATS_GRP(pcie, 0);
1712-
static MLX5E_DEFINE_STATS_GRP(per_prio, 0);
1713-
static MLX5E_DEFINE_STATS_GRP(pme, 0);
1714-
static MLX5E_DEFINE_STATS_GRP(channels, 0);
1715-
static MLX5E_DEFINE_STATS_GRP(per_port_buff_congest, 0);
1703+
MLX5E_DEFINE_STATS_GRP(sw, 0);
1704+
MLX5E_DEFINE_STATS_GRP(qcnt, MLX5E_NDO_UPDATE_STATS);
1705+
MLX5E_DEFINE_STATS_GRP(vnic_env, 0);
1706+
MLX5E_DEFINE_STATS_GRP(vport, MLX5E_NDO_UPDATE_STATS);
1707+
MLX5E_DEFINE_STATS_GRP(802_3, MLX5E_NDO_UPDATE_STATS);
1708+
MLX5E_DEFINE_STATS_GRP(2863, 0);
1709+
MLX5E_DEFINE_STATS_GRP(2819, 0);
1710+
MLX5E_DEFINE_STATS_GRP(phy, 0);
1711+
MLX5E_DEFINE_STATS_GRP(pcie, 0);
1712+
MLX5E_DEFINE_STATS_GRP(per_prio, 0);
1713+
MLX5E_DEFINE_STATS_GRP(pme, 0);
1714+
MLX5E_DEFINE_STATS_GRP(channels, 0);
1715+
MLX5E_DEFINE_STATS_GRP(per_port_buff_congest, 0);
17161716
static MLX5E_DEFINE_STATS_GRP(eth_ext, 0);
17171717
static MLX5E_DEFINE_STATS_GRP(ipsec, 0);
17181718
static MLX5E_DEFINE_STATS_GRP(tls, 0);

drivers/net/ethernet/mellanox/mlx5/core/en_stats.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,4 +378,18 @@ unsigned int mlx5e_nic_stats_grps_num(struct mlx5e_priv *priv);
378378

379379
MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(802_3);
380380

381+
extern MLX5E_DECLARE_STATS_GRP(sw);
382+
extern MLX5E_DECLARE_STATS_GRP(qcnt);
383+
extern MLX5E_DECLARE_STATS_GRP(vnic_env);
384+
extern MLX5E_DECLARE_STATS_GRP(vport);
385+
extern MLX5E_DECLARE_STATS_GRP(802_3);
386+
extern MLX5E_DECLARE_STATS_GRP(2863);
387+
extern MLX5E_DECLARE_STATS_GRP(2819);
388+
extern MLX5E_DECLARE_STATS_GRP(phy);
389+
extern MLX5E_DECLARE_STATS_GRP(pcie);
390+
extern MLX5E_DECLARE_STATS_GRP(per_prio);
391+
extern MLX5E_DECLARE_STATS_GRP(pme);
392+
extern MLX5E_DECLARE_STATS_GRP(channels);
393+
extern MLX5E_DECLARE_STATS_GRP(per_port_buff_congest);
394+
381395
#endif /* __MLX5_EN_STATS_H__ */

drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,28 @@ static void mlx5i_cleanup_rx(struct mlx5e_priv *priv)
419419
mlx5e_destroy_q_counters(priv);
420420
}
421421

422+
/* The stats groups order is opposite to the update_stats() order calls */
423+
static mlx5e_stats_grp_t mlx5i_stats_grps[] = {
424+
&MLX5E_STATS_GRP(sw),
425+
&MLX5E_STATS_GRP(qcnt),
426+
&MLX5E_STATS_GRP(vnic_env),
427+
&MLX5E_STATS_GRP(vport),
428+
&MLX5E_STATS_GRP(802_3),
429+
&MLX5E_STATS_GRP(2863),
430+
&MLX5E_STATS_GRP(2819),
431+
&MLX5E_STATS_GRP(phy),
432+
&MLX5E_STATS_GRP(pcie),
433+
&MLX5E_STATS_GRP(per_prio),
434+
&MLX5E_STATS_GRP(pme),
435+
&MLX5E_STATS_GRP(channels),
436+
&MLX5E_STATS_GRP(per_port_buff_congest),
437+
};
438+
439+
static unsigned int mlx5i_stats_grps_num(struct mlx5e_priv *priv)
440+
{
441+
return ARRAY_SIZE(mlx5i_stats_grps);
442+
}
443+
422444
static const struct mlx5e_profile mlx5i_nic_profile = {
423445
.init = mlx5i_init,
424446
.cleanup = mlx5i_cleanup,
@@ -435,8 +457,8 @@ static const struct mlx5e_profile mlx5i_nic_profile = {
435457
.rx_handlers.handle_rx_cqe_mpwqe = NULL, /* Not supported */
436458
.max_tc = MLX5I_MAX_NUM_TC,
437459
.rq_groups = MLX5E_NUM_RQ_GROUPS(REGULAR),
438-
.stats_grps = mlx5e_nic_stats_grps,
439-
.stats_grps_num = mlx5e_nic_stats_grps_num,
460+
.stats_grps = mlx5i_stats_grps,
461+
.stats_grps_num = mlx5i_stats_grps_num,
440462
};
441463

442464
/* mlx5i netdev NDos */

0 commit comments

Comments
 (0)