Skip to content

Commit 2c81ca7

Browse files
nathanlynchmpe
authored andcommitted
powerpc/tracing: tracepoints for RTAS entry and exit
Add two sets of tracepoints to be used around RTAS entry: * rtas_input/rtas_output, which emit the function name, its inputs, the returned status, and any other outputs. These produce an API-level record of OS<->RTAS activity. * rtas_ll_entry/rtas_ll_exit, which are lower-level and emit the entire contents of the parameter block (aka rtas_args) on entry and exit. Likely useful only for debugging. With uses of these tracepoints in do_enter_rtas() to be added in the following patch, examples of get-time-of-day and event-scan functions as rendered by trace-cmd (with some multi-line formatting manually imposed on the rtas_ll_* entries to avoid extremely long lines in the commit message): cat-36800 [059] 4978.518303: rtas_input: get-time-of-day arguments: cat-36800 [059] 4978.518306: rtas_ll_entry: token=3 nargs=0 nret=8 params: [0]=0x00000000 [1]=0x00000000 [2]=0x00000000 [3]=0x00000000 [4]=0x00000000 [5]=0x00000000 [6]=0x00000000 [7]=0x00000000 [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000 [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000 cat-36800 [059] 4978.518366: rtas_ll_exit: token=3 nargs=0 nret=8 params: [0]=0x00000000 [1]=0x000007e6 [2]=0x0000000b [3]=0x00000001 [4]=0x00000000 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40 [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000 [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000 cat-36800 [059] 4978.518366: rtas_output: get-time-of-day status: 0, other outputs: 2022 11 1 0 14 8 772648000 kworker/39:1-336 [039] 4982.731623: rtas_input: event-scan arguments: 4294967295 0 80484920 2048 kworker/39:1-336 [039] 4982.731626: rtas_ll_entry: token=6 nargs=4 nret=1 params: [0]=0xffffffff [1]=0x00000000 [2]=0x04cc1a38 [3]=0x00000800 [4]=0x00000000 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40 [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000 [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000 kworker/39:1-336 [039] 4982.731676: rtas_ll_exit: token=6 nargs=4 nret=1 params: [0]=0xffffffff [1]=0x00000000 [2]=0x04cc1a38 [3]=0x00000800 [4]=0x00000001 [5]=0x0000000e [6]=0x00000008 [7]=0x2e0dac40 [8]=0x00000000 [9]=0x00000000 [10]=0x00000000 [11]=0x00000000 [12]=0x00000000 [13]=0x00000000 [14]=0x00000000 [15]=0x00000000 kworker/39:1-336 [039] 4982.731677: rtas_output: event-scan status: 1, other outputs: Signed-off-by: Nathan Lynch <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 77f85f6 commit 2c81ca7

File tree

1 file changed

+103
-0
lines changed

1 file changed

+103
-0
lines changed

arch/powerpc/include/asm/trace.h

Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,109 @@ TRACE_EVENT_FN_COND(hcall_exit,
119119
);
120120
#endif
121121

122+
#ifdef CONFIG_PPC_RTAS
123+
124+
#include <asm/rtas-types.h>
125+
126+
TRACE_EVENT(rtas_input,
127+
128+
TP_PROTO(struct rtas_args *rtas_args, const char *name),
129+
130+
TP_ARGS(rtas_args, name),
131+
132+
TP_STRUCT__entry(
133+
__field(__u32, nargs)
134+
__string(name, name)
135+
__dynamic_array(__u32, inputs, be32_to_cpu(rtas_args->nargs))
136+
),
137+
138+
TP_fast_assign(
139+
__entry->nargs = be32_to_cpu(rtas_args->nargs);
140+
__assign_str(name, name);
141+
be32_to_cpu_array(__get_dynamic_array(inputs), rtas_args->args, __entry->nargs);
142+
),
143+
144+
TP_printk("%s arguments: %s", __get_str(name),
145+
__print_array(__get_dynamic_array(inputs), __entry->nargs, 4)
146+
)
147+
);
148+
149+
TRACE_EVENT(rtas_output,
150+
151+
TP_PROTO(struct rtas_args *rtas_args, const char *name),
152+
153+
TP_ARGS(rtas_args, name),
154+
155+
TP_STRUCT__entry(
156+
__field(__u32, nr_other)
157+
__field(__s32, status)
158+
__string(name, name)
159+
__dynamic_array(__u32, other_outputs, be32_to_cpu(rtas_args->nret) - 1)
160+
),
161+
162+
TP_fast_assign(
163+
__entry->nr_other = be32_to_cpu(rtas_args->nret) - 1;
164+
__entry->status = be32_to_cpu(rtas_args->rets[0]);
165+
__assign_str(name, name);
166+
be32_to_cpu_array(__get_dynamic_array(other_outputs),
167+
&rtas_args->rets[1], __entry->nr_other);
168+
),
169+
170+
TP_printk("%s status: %d, other outputs: %s", __get_str(name), __entry->status,
171+
__print_array(__get_dynamic_array(other_outputs),
172+
__entry->nr_other, 4)
173+
)
174+
);
175+
176+
DECLARE_EVENT_CLASS(rtas_parameter_block,
177+
178+
TP_PROTO(struct rtas_args *rtas_args),
179+
180+
TP_ARGS(rtas_args),
181+
182+
TP_STRUCT__entry(
183+
__field(u32, token)
184+
__field(u32, nargs)
185+
__field(u32, nret)
186+
__array(__u32, params, 16)
187+
),
188+
189+
TP_fast_assign(
190+
__entry->token = be32_to_cpu(rtas_args->token);
191+
__entry->nargs = be32_to_cpu(rtas_args->nargs);
192+
__entry->nret = be32_to_cpu(rtas_args->nret);
193+
be32_to_cpu_array(__entry->params, rtas_args->args, ARRAY_SIZE(rtas_args->args));
194+
),
195+
196+
TP_printk("token=%u nargs=%u nret=%u params:"
197+
" [0]=0x%08x [1]=0x%08x [2]=0x%08x [3]=0x%08x"
198+
" [4]=0x%08x [5]=0x%08x [6]=0x%08x [7]=0x%08x"
199+
" [8]=0x%08x [9]=0x%08x [10]=0x%08x [11]=0x%08x"
200+
" [12]=0x%08x [13]=0x%08x [14]=0x%08x [15]=0x%08x",
201+
__entry->token, __entry->nargs, __entry->nret,
202+
__entry->params[0], __entry->params[1], __entry->params[2], __entry->params[3],
203+
__entry->params[4], __entry->params[5], __entry->params[6], __entry->params[7],
204+
__entry->params[8], __entry->params[9], __entry->params[10], __entry->params[11],
205+
__entry->params[12], __entry->params[13], __entry->params[14], __entry->params[15]
206+
)
207+
);
208+
209+
DEFINE_EVENT(rtas_parameter_block, rtas_ll_entry,
210+
211+
TP_PROTO(struct rtas_args *rtas_args),
212+
213+
TP_ARGS(rtas_args)
214+
);
215+
216+
DEFINE_EVENT(rtas_parameter_block, rtas_ll_exit,
217+
218+
TP_PROTO(struct rtas_args *rtas_args),
219+
220+
TP_ARGS(rtas_args)
221+
);
222+
223+
#endif /* CONFIG_PPC_RTAS */
224+
122225
#ifdef CONFIG_PPC_POWERNV
123226
extern int opal_tracepoint_regfunc(void);
124227
extern void opal_tracepoint_unregfunc(void);

0 commit comments

Comments
 (0)