Skip to content

Commit 2d04e1c

Browse files
Binary-EaterSaeed Mahameed
authored andcommitted
net/mlx5: Fix orthography errors in documentation
Improve general readability of the device driver documentation. Signed-off-by: Rahul Rameshbabu <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Reviewed-by: Gal Pressman <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent daab2e9 commit 2d04e1c

File tree

1 file changed

+41
-41
lines changed
  • Documentation/networking/device_drivers/ethernet/mellanox

1 file changed

+41
-41
lines changed

Documentation/networking/device_drivers/ethernet/mellanox/mlx5.rst

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Enabling the driver and kconfig options
2525
| at build time via kernel Kconfig flags.
2626
| Basic features, ethernet net device rx/tx offloads and XDP, are available with the most basic flags
2727
| CONFIG_MLX5_CORE=y/m and CONFIG_MLX5_CORE_EN=y.
28-
| For the list of advanced features please see below.
28+
| For the list of advanced features, please see below.
2929
3030
**CONFIG_MLX5_CORE=(y/m/n)** (module mlx5_core.ko)
3131

@@ -89,11 +89,11 @@ Enabling the driver and kconfig options
8989

9090
**CONFIG_MLX5_EN_IPSEC=(y/n)**
9191

92-
| Enables `IPSec XFRM cryptography-offload accelaration <http://www.mellanox.com/related-docs/prod_software/Mellanox_Innova_IPsec_Ethernet_Adapter_Card_User_Manual.pdf>`_.
92+
| Enables `IPSec XFRM cryptography-offload acceleration <http://www.mellanox.com/related-docs/prod_software/Mellanox_Innova_IPsec_Ethernet_Adapter_Card_User_Manual.pdf>`_.
9393
9494
**CONFIG_MLX5_EN_TLS=(y/n)**
9595

96-
| TLS cryptography-offload accelaration.
96+
| TLS cryptography-offload acceleration.
9797
9898

9999
**CONFIG_MLX5_INFINIBAND=(y/n/m)** (module mlx5_ib.ko)
@@ -139,14 +139,14 @@ flow_steering_mode: Device flow steering mode
139139
The flow steering mode parameter controls the flow steering mode of the driver.
140140
Two modes are supported:
141141
1. 'dmfs' - Device managed flow steering.
142-
2. 'smfs - Software/Driver managed flow steering.
142+
2. 'smfs' - Software/Driver managed flow steering.
143143

144144
In DMFS mode, the HW steering entities are created and managed through the
145145
Firmware.
146146
In SMFS mode, the HW steering entities are created and managed though by
147-
the driver directly into Hardware without firmware intervention.
147+
the driver directly into hardware without firmware intervention.
148148

149-
SMFS mode is faster and provides better rule inserstion rate compared to default DMFS mode.
149+
SMFS mode is faster and provides better rule insertion rate compared to default DMFS mode.
150150

151151
User command examples:
152152

@@ -165,9 +165,9 @@ User command examples:
165165
enable_roce: RoCE enablement state
166166
----------------------------------
167167
RoCE enablement state controls driver support for RoCE traffic.
168-
When RoCE is disabled, there is no gid table, only raw ethernet QPs are supported and traffic on the well known UDP RoCE port is handled as raw ethernet traffic.
168+
When RoCE is disabled, there is no gid table, only raw ethernet QPs are supported and traffic on the well-known UDP RoCE port is handled as raw ethernet traffic.
169169

170-
To change RoCE enablement state a user must change the driverinit cmode value and run devlink reload.
170+
To change RoCE enablement state, a user must change the driverinit cmode value and run devlink reload.
171171

172172
User command examples:
173173

@@ -186,7 +186,7 @@ User command examples:
186186

187187
esw_port_metadata: Eswitch port metadata state
188188
----------------------------------------------
189-
When applicable, disabling Eswitch metadata can increase packet rate
189+
When applicable, disabling eswitch metadata can increase packet rate
190190
up to 20% depending on the use case and packet sizes.
191191

192192
Eswitch port metadata state controls whether to internally tag packets with
@@ -253,26 +253,26 @@ mlx5 subfunction
253253
================
254254
mlx5 supports subfunction management using devlink port (see :ref:`Documentation/networking/devlink/devlink-port.rst <devlink_port>`) interface.
255255

256-
A Subfunction has its own function capabilities and its own resources. This
256+
A subfunction has its own function capabilities and its own resources. This
257257
means a subfunction has its own dedicated queues (txq, rxq, cq, eq). These
258258
queues are neither shared nor stolen from the parent PCI function.
259259

260-
When a subfunction is RDMA capable, it has its own QP1, GID table and rdma
260+
When a subfunction is RDMA capable, it has its own QP1, GID table, and RDMA
261261
resources neither shared nor stolen from the parent PCI function.
262262

263263
A subfunction has a dedicated window in PCI BAR space that is not shared
264-
with ther other subfunctions or the parent PCI function. This ensures that all
265-
devices (netdev, rdma, vdpa etc.) of the subfunction accesses only assigned
264+
with the other subfunctions or the parent PCI function. This ensures that all
265+
devices (netdev, rdma, vdpa, etc.) of the subfunction accesses only assigned
266266
PCI BAR space.
267267

268-
A Subfunction supports eswitch representation through which it supports tc
268+
A subfunction supports eswitch representation through which it supports tc
269269
offloads. The user configures eswitch to send/receive packets from/to
270270
the subfunction port.
271271

272272
Subfunctions share PCI level resources such as PCI MSI-X IRQs with
273273
other subfunctions and/or with its parent PCI function.
274274

275-
Example mlx5 software, system and device view::
275+
Example mlx5 software, system, and device view::
276276

277277
_______
278278
| admin |
@@ -310,7 +310,7 @@ Example mlx5 software, system and device view::
310310
| (device add/del)
311311
_____|____ ____|________
312312
| | | subfunction |
313-
| PCI NIC |---- activate/deactive events---->| host driver |
313+
| PCI NIC |--- activate/deactivate events--->| host driver |
314314
|__________| | (mlx5_core) |
315315
|_____________|
316316

@@ -320,7 +320,7 @@ Subfunction is created using devlink port interface.
320320

321321
$ devlink dev eswitch set pci/0000:06:00.0 mode switchdev
322322

323-
- Add a devlink port of subfunction flaovur::
323+
- Add a devlink port of subfunction flavour::
324324

325325
$ devlink port add pci/0000:06:00.0 flavour pcisf pfnum 0 sfnum 88
326326
pci/0000:06:00.0/32768: type eth netdev eth6 flavour pcisf controller 0 pfnum 0 sfnum 88 external false splittable false
@@ -379,18 +379,18 @@ device created for the PCI VF/SF.
379379
function:
380380
hw_addr 00:00:00:00:00:00
381381

382-
- Set the MAC address of the VF identified by its unique devlink port index::
382+
- Set the MAC address of the SF identified by its unique devlink port index::
383383

384384
$ devlink port function set pci/0000:06:00.0/32768 hw_addr 00:00:00:00:88:88
385385

386386
$ devlink port show pci/0000:06:00.0/32768
387-
pci/0000:06:00.0/32768: type eth netdev enp6s0pf0sf88 flavour pcivf pfnum 0 sfnum 88
387+
pci/0000:06:00.0/32768: type eth netdev enp6s0pf0sf88 flavour pcisf pfnum 0 sfnum 88
388388
function:
389389
hw_addr 00:00:00:00:88:88
390390

391391
SF state setup
392392
--------------
393-
To use the SF, the user must active the SF using the SF function state
393+
To use the SF, the user must activate the SF using the SF function state
394394
attribute.
395395

396396
- Get the state of the SF identified by its unique devlink port index::
@@ -447,7 +447,7 @@ for it.
447447

448448
Additionally, the SF port also gets the event when the driver attaches to the
449449
auxiliary device of the subfunction. This results in changing the operational
450-
state of the function. This provides visiblity to the user to decide when is it
450+
state of the function. This provides visibility to the user to decide when is it
451451
safe to delete the SF port for graceful termination of the subfunction.
452452

453453
- Show the SF port operational state::
@@ -464,14 +464,14 @@ tx reporter
464464
-----------
465465
The tx reporter is responsible for reporting and recovering of the following two error scenarios:
466466

467-
- TX timeout
467+
- tx timeout
468468
Report on kernel tx timeout detection.
469469
Recover by searching lost interrupts.
470-
- TX error completion
470+
- tx error completion
471471
Report on error tx completion.
472-
Recover by flushing the TX queue and reset it.
472+
Recover by flushing the tx queue and reset it.
473473

474-
TX reporter also support on demand diagnose callback, on which it provides
474+
tx reporter also support on demand diagnose callback, on which it provides
475475
real time information of its send queues status.
476476

477477
User commands examples:
@@ -491,32 +491,32 @@ rx reporter
491491
-----------
492492
The rx reporter is responsible for reporting and recovering of the following two error scenarios:
493493

494-
- RX queues initialization (population) timeout
495-
RX queues descriptors population on ring initialization is done in
496-
napi context via triggering an irq, in case of a failure to get
497-
the minimum amount of descriptors, a timeout would occur and it
498-
could be recoverable by polling the EQ (Event Queue).
499-
- RX completions with errors (reported by HW on interrupt context)
494+
- rx queues' initialization (population) timeout
495+
Population of rx queues' descriptors on ring initialization is done
496+
in napi context via triggering an irq. In case of a failure to get
497+
the minimum amount of descriptors, a timeout would occur, and
498+
descriptors could be recovered by polling the EQ (Event Queue).
499+
- rx completions with errors (reported by HW on interrupt context)
500500
Report on rx completion error.
501501
Recover (if needed) by flushing the related queue and reset it.
502502

503-
RX reporter also supports on demand diagnose callback, on which it
504-
provides real time information of its receive queues status.
503+
rx reporter also supports on demand diagnose callback, on which it
504+
provides real time information of its receive queues' status.
505505

506-
- Diagnose rx queues status, and corresponding completion queue::
506+
- Diagnose rx queues' status and corresponding completion queue::
507507

508508
$ devlink health diagnose pci/0000:82:00.0 reporter rx
509509

510-
NOTE: This command has valid output only when interface is up, otherwise the command has empty output.
510+
NOTE: This command has valid output only when interface is up. Otherwise, the command has empty output.
511511

512512
- Show number of rx errors indicated, number of recover flows ended successfully,
513-
is autorecover enabled and graceful period from last recover::
513+
is autorecover enabled, and graceful period from last recover::
514514

515515
$ devlink health show pci/0000:82:00.0 reporter rx
516516

517517
fw reporter
518518
-----------
519-
The fw reporter implements diagnose and dump callbacks.
519+
The fw reporter implements `diagnose` and `dump` callbacks.
520520
It follows symptoms of fw error such as fw syndrome by triggering
521521
fw core dump and storing it into the dump buffer.
522522
The fw reporter diagnose command can be triggered any time by the user to check
@@ -537,7 +537,7 @@ running it on other PF or any VF will return "Operation not permitted".
537537

538538
fw fatal reporter
539539
-----------------
540-
The fw fatal reporter implements dump and recover callbacks.
540+
The fw fatal reporter implements `dump` and `recover` callbacks.
541541
It follows fatal errors indications by CR-space dump and recover flow.
542542
The CR-space dump uses vsc interface which is valid even if the FW command
543543
interface is not functional, which is the case in most FW fatal errors.
@@ -552,7 +552,7 @@ User commands examples:
552552

553553
$ devlink health recover pci/0000:82:00.0 reporter fw_fatal
554554

555-
- Read FW CR-space dump if already strored or trigger new one::
555+
- Read FW CR-space dump if already stored or trigger new one::
556556

557557
$ devlink health dump show pci/0000:82:00.1 reporter fw_fatal
558558

@@ -561,10 +561,10 @@ NOTE: This command can run only on PF.
561561
mlx5 tracepoints
562562
================
563563

564-
mlx5 driver provides internal trace points for tracking and debugging using
564+
mlx5 driver provides internal tracepoints for tracking and debugging using
565565
kernel tracepoints interfaces (refer to Documentation/trace/ftrace.rst).
566566

567-
For the list of support mlx5 events check /sys/kernel/debug/tracing/events/mlx5/
567+
For the list of support mlx5 events, check `/sys/kernel/debug/tracing/events/mlx5/`.
568568

569569
tc and eswitch offloads tracepoints:
570570

0 commit comments

Comments
 (0)