Skip to content

Commit 30d3f01

Browse files
Michal Hockotorvalds
authored andcommitted
mm/vmalloc: be more explicit about supported gfp flags.
Commit b7d90e7 ("mm/vmalloc: be more explicit about supported gfp flags") has been merged prematurely without the rest of the series and without addressed review feedback from Neil. Fix that up now. Only wording is changed slightly. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Michal Hocko <[email protected]> Reviewed-by: Uladzislau Rezki (Sony) <[email protected]> Acked-by: Vlastimil Babka <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Dave Chinner <[email protected]> Cc: Ilya Dryomov <[email protected]> Cc: Jeff Layton <[email protected]> Cc: Neil Brown <[email protected]> Cc: Sebastian Andrzej Siewior <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 9376130 commit 30d3f01

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

mm/vmalloc.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3031,12 +3031,14 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
30313031
*
30323032
* Allocate enough pages to cover @size from the page level
30333033
* allocator with @gfp_mask flags. Please note that the full set of gfp
3034-
* flags are not supported. GFP_KERNEL would be a preferred allocation mode
3035-
* but GFP_NOFS and GFP_NOIO are supported as well. Zone modifiers are not
3036-
* supported. From the reclaim modifiers__GFP_DIRECT_RECLAIM is required (aka
3037-
* GFP_NOWAIT is not supported) and only __GFP_NOFAIL is supported (aka
3038-
* __GFP_NORETRY and __GFP_RETRY_MAYFAIL are not supported).
3039-
* __GFP_NOWARN can be used to suppress error messages about failures.
3034+
* flags are not supported. GFP_KERNEL, GFP_NOFS and GFP_NOIO are all
3035+
* supported.
3036+
* Zone modifiers are not supported. From the reclaim modifiers
3037+
* __GFP_DIRECT_RECLAIM is required (aka GFP_NOWAIT is not supported)
3038+
* and only __GFP_NOFAIL is supported (i.e. __GFP_NORETRY and
3039+
* __GFP_RETRY_MAYFAIL are not supported).
3040+
*
3041+
* __GFP_NOWARN can be used to suppress failures messages.
30403042
*
30413043
* Map them into contiguous kernel virtual space, using a pagetable
30423044
* protection of @prot.

0 commit comments

Comments
 (0)