Skip to content

Commit 319b6d4

Browse files
Alex ElderPaolo Abeni
authored andcommitted
net: ipa: fix two minor ipa_cmd problems
In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function does not exist. So delete that declaration. Also, for some reason ipa_cmd_init() never gets called. It isn't really critical--it just validates that some memory offsets and a size can be represented in some register fields, and they won't fail with current data. Regardless, call the function in ipa_probe(). Signed-off-by: Alex Elder <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent f2e4e9e commit 319b6d4

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

drivers/net/ipa/ipa_cmd.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,6 @@ enum ipa_cmd_opcode {
5353
bool ipa_cmd_table_init_valid(struct ipa *ipa, const struct ipa_mem *mem,
5454
bool route);
5555

56-
/**
57-
* ipa_cmd_data_valid() - Validate command-realted configuration is valid
58-
* @ipa: - IPA pointer
59-
*
60-
* Return: true if assumptions required for command are valid
61-
*/
62-
bool ipa_cmd_data_valid(struct ipa *ipa);
63-
6456
/**
6557
* ipa_cmd_pool_init() - initialize command channel pools
6658
* @channel: AP->IPA command TX GSI channel pointer

drivers/net/ipa/ipa_main.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,10 @@ static int ipa_probe(struct platform_device *pdev)
865865
if (ret)
866866
goto err_reg_exit;
867867

868+
ret = ipa_cmd_init(ipa);
869+
if (ret)
870+
goto err_mem_exit;
871+
868872
ret = gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count,
869873
data->endpoint_data);
870874
if (ret)

0 commit comments

Comments
 (0)