ALSA: usb-audio: localize function without external linkage

takaswie · tiwai · commit 34371d236eab · 2017-02-20T21:53:14.000+01:00
When accessed inner a file, functions should have static qualifier for local-linkage. This commit fixes the bug. Sparse generated below warning. sound/usb/mixer_us16x08.c:1043:32: warning: symbol 'snd_us16x08_create_meter_store' was not declared. Should it be static? Fixes: d2bb390 ("ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
@@ -1040,7 +1040,7 @@ static struct snd_us16x08_eq_store *snd_us16x08_create_eq_store(void)
 	return tmp;
 }
 
-struct snd_us16x08_meter_store *snd_us16x08_create_meter_store(void)
+static struct snd_us16x08_meter_store *snd_us16x08_create_meter_store(void)
 {
 	struct snd_us16x08_meter_store *tmp =
 		kzalloc(sizeof(struct snd_us16x08_meter_store), GFP_KERNEL);

Original file line number	Diff line number	Diff line change
`@@ -1040,7 +1040,7 @@ static struct snd_us16x08_eq_store *snd_us16x08_create_eq_store(void)`
`1040`	`1040`	`return tmp;`
`1041`	`1041`	`}`
`1042`	`1042`
`1043`		`-struct snd_us16x08_meter_store *snd_us16x08_create_meter_store(void)`
	`1043`	`+static struct snd_us16x08_meter_store *snd_us16x08_create_meter_store(void)`
`1044`	`1044`	`{`
`1045`	`1045`	`struct snd_us16x08_meter_store *tmp =`
`1046`	`1046`	`kzalloc(sizeof(struct snd_us16x08_meter_store), GFP_KERNEL);`