Skip to content

Commit 354e923

Browse files
akpm00torvalds
authored andcommitted
revert "fs/binfmt_elf: fix PT_LOAD p_align values for loaders"
Commit 925346c ("fs/binfmt_elf: fix PT_LOAD p_align values for loaders") was an attempt to fix regressions due to 9630f0d ("fs/binfmt_elf: use PT_LOAD p_align values for static PIE"). But regressionss continue to be reported: https://lore.kernel.org/lkml/[email protected]/ https://bugzilla.kernel.org/show_bug.cgi?id=215720 https://lkml.kernel.org/r/[email protected] This patch reverts the fix, so the original can also be reverted. Fixes: 925346c ("fs/binfmt_elf: fix PT_LOAD p_align values for loaders") Cc: H.J. Lu <[email protected]> Cc: Chris Kennelly <[email protected]> Cc: Al Viro <[email protected]> Cc: Alexey Dobriyan <[email protected]> Cc: Song Liu <[email protected]> Cc: David Rientjes <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Hugh Dickins <[email protected]> Cc: Suren Baghdasaryan <[email protected]> Cc: Sandeep Patil <[email protected]> Cc: Fangrui Song <[email protected]> Cc: Nick Desaulniers <[email protected]> Cc: Kirill A. Shutemov <[email protected]> Cc: Mike Kravetz <[email protected]> Cc: Shuah Khan <[email protected]> Cc: Thorsten Leemhuis <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 5a31741 commit 354e923

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/binfmt_elf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
11181118
* without MAP_FIXED nor MAP_FIXED_NOREPLACE).
11191119
*/
11201120
alignment = maximum_alignment(elf_phdata, elf_ex->e_phnum);
1121-
if (interpreter || alignment > ELF_MIN_ALIGN) {
1121+
if (alignment > ELF_MIN_ALIGN) {
11221122
load_bias = ELF_ET_DYN_BASE;
11231123
if (current->flags & PF_RANDOMIZE)
11241124
load_bias += arch_mmap_rnd();

0 commit comments

Comments
 (0)