Skip to content

Commit 36e239b

Browse files
committed
drm/fb-helper: drop redundant pixclock check from drm_fb_helper_set_par()
The fb_check_var hook is supposed to validate all this stuff. Any errors from fb_set_par are considered driver/hw issues and resulting in dmesg warnings. Luckily we do fix up the pixclock already, so this is all fine. Signed-off-by: Daniel Vetter <[email protected]> Reviewed-by: Javier Martinez Canillas <[email protected]> Cc: Maarten Lankhorst <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 1935f0d commit 36e239b

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/gpu/drm/drm_fb_helper.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,11 +1641,6 @@ int drm_fb_helper_set_par(struct fb_info *info)
16411641
if (oops_in_progress)
16421642
return -EBUSY;
16431643

1644-
if (var->pixclock != 0) {
1645-
drm_err(fb_helper->dev, "PIXEL CLOCK SET\n");
1646-
return -EINVAL;
1647-
}
1648-
16491644
/*
16501645
* Normally we want to make sure that a kms master takes precedence over
16511646
* fbdev, to avoid fbdev flickering and occasionally stealing the

0 commit comments

Comments
 (0)