Skip to content

Commit 386f310

Browse files
Fernando Guzman LugoLuis Henriques
authored andcommitted
mailbox: change full flag per mailbox queue instead of global
As pointed by Ohad Ben-Cohen, the variable rq_full flag is a global variable, so if there are multiple mailbox users there will be conflics. Now there is a full flag per mailbox queue. Version 2: - Rebase to the latest. Reported-by: Ohad Ben-Cohen <[email protected]> Signed-off-by: Fernando Guzman Lugo <[email protected]>
1 parent 8574d2d commit 386f310

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm/plat-omap/mailbox.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ static void mbox_rx_work(struct work_struct *work)
153153
WARN_ON(len != sizeof(msg));
154154

155155
blocking_notifier_call_chain(&mq->mbox->notifier, len,
156-
(void *)msg);
156+
(void *)msg);
157157
spin_lock_irq(&mq->lock);
158158
if (mq->full) {
159159
mq->full = false;
@@ -199,7 +199,7 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox)
199199
msg_rx = true;
200200
if (unlikely(kfifo_avail(&mq->fifo) < sizeof(msg))) {
201201
omap_mbox_disable_irq(mbox_curr, IRQ_RX);
202-
rq_full = true;
202+
mq->full = true;
203203
goto nomem;
204204
}
205205

0 commit comments

Comments
 (0)