Skip to content

Commit 3ba1eef

Browse files
hreineckemartinkpetersen
authored andcommitted
scsi: fnic: Kill 'exclude_id' argument to fnic_cleanup_io()
'exclude_id' is always SCSI_NO_TAG which will never be reached when traversing the list of tags. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ming Lei <[email protected]> Signed-off-by: Hannes Reinecke <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent fc09acb commit 3ba1eef

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/scsi/fnic/fnic_scsi.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static const char *fnic_fcpio_status_to_str(unsigned int status)
102102
return fcpio_status_str[status];
103103
}
104104

105-
static void fnic_cleanup_io(struct fnic *fnic, int exclude_id);
105+
static void fnic_cleanup_io(struct fnic *fnic);
106106

107107
static inline spinlock_t *fnic_io_lock_hash(struct fnic *fnic,
108108
struct scsi_cmnd *sc)
@@ -638,7 +638,7 @@ static int fnic_fcpio_fw_reset_cmpl_handler(struct fnic *fnic,
638638
atomic64_inc(&reset_stats->fw_reset_completions);
639639

640640
/* Clean up all outstanding io requests */
641-
fnic_cleanup_io(fnic, SCSI_NO_TAG);
641+
fnic_cleanup_io(fnic);
642642

643643
atomic64_set(&fnic->fnic_stats.fw_stats.active_fw_reqs, 0);
644644
atomic64_set(&fnic->fnic_stats.io_stats.active_ios, 0);
@@ -1361,7 +1361,7 @@ int fnic_wq_copy_cmpl_handler(struct fnic *fnic, int copy_work_to_do)
13611361
return wq_work_done;
13621362
}
13631363

1364-
static void fnic_cleanup_io(struct fnic *fnic, int exclude_id)
1364+
static void fnic_cleanup_io(struct fnic *fnic)
13651365
{
13661366
int i;
13671367
struct fnic_io_req *io_req;
@@ -1372,9 +1372,6 @@ static void fnic_cleanup_io(struct fnic *fnic, int exclude_id)
13721372
struct fnic_stats *fnic_stats = &fnic->fnic_stats;
13731373

13741374
for (i = 0; i < fnic->fnic_max_tag_id; i++) {
1375-
if (i == exclude_id)
1376-
continue;
1377-
13781375
io_lock = fnic_io_lock_tag(fnic, i);
13791376
spin_lock_irqsave(io_lock, flags);
13801377
sc = scsi_host_find_tag(fnic->lport->host, i);

0 commit comments

Comments
 (0)