Skip to content

Commit 3f416f2

Browse files
olsajiriacmel
authored andcommitted
perf stat: Do not clean event's private stats
Mel reported stddev reporting was broken due to following commit: 106a94a ("perf stat: Introduce read_counters function") This commit merged interval and overall counters reading into single read_counters function. The old interval code cleaned the stddev data for some reason (it's never displayed in interval mode) and the mentioned commit kept on cleaning the stddev data in merged function, which resulted in the stddev not being displayed. Removing the wrong stddev data cleanup init_stats call. Reported-and-Tested-by: Mel Gorman <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> Cc: David Ahern <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: [email protected] # v4.2+ Fixes: 106a94a ("perf stat: Introduce read_counters function") Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 0805909 commit 3f416f2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

tools/perf/util/stat.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
310310
int i, ret;
311311

312312
aggr->val = aggr->ena = aggr->run = 0;
313-
init_stats(ps->res_stats);
314313

315314
if (counter->per_pkg)
316315
zero_per_pkg(counter);

0 commit comments

Comments
 (0)