Skip to content

Commit 40d489f

Browse files
committed
drm/i915/ddi: handle 128b/132b SST in intel_ddi_read_func_ctl()
We'll only ever get here in MST mode from MST stream encoders; the primary encoder's ->get_config() won't be called when we've detected it's MST. v2: Read mst_master_transcoder in 128b/132b SST path (Imre) Reviewed-by: Imre Deak <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/436854c0bb6ab5c14c3d3837694ea60ac2fbaba2.1735912293.git.jani.nikula@intel.com
1 parent 35d2e4b commit 40d489f

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

drivers/gpu/drm/i915/display/intel_ddi.c

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4049,6 +4049,11 @@ static void intel_ddi_read_func_ctl_dp_sst(struct intel_encoder *encoder,
40494049
crtc_state->lane_count =
40504050
((ddi_func_ctl & DDI_PORT_WIDTH_MASK) >> DDI_PORT_WIDTH_SHIFT) + 1;
40514051

4052+
if (DISPLAY_VER(display) >= 12 &&
4053+
(ddi_func_ctl & TRANS_DDI_MODE_SELECT_MASK) == TRANS_DDI_MODE_SELECT_FDI_OR_128B132B)
4054+
crtc_state->mst_master_transcoder =
4055+
REG_FIELD_GET(TRANS_DDI_MST_TRANSPORT_SELECT_MASK, ddi_func_ctl);
4056+
40524057
intel_cpu_transcoder_get_m1_n1(crtc, cpu_transcoder, &crtc_state->dp_m_n);
40534058
intel_cpu_transcoder_get_m2_n2(crtc, cpu_transcoder, &crtc_state->dp_m2_n2);
40544059

@@ -4143,9 +4148,19 @@ static void intel_ddi_read_func_ctl(struct intel_encoder *encoder,
41434148
intel_ddi_read_func_ctl_fdi(encoder, pipe_config, ddi_func_ctl);
41444149
} else if (ddi_mode == TRANS_DDI_MODE_SELECT_DP_SST) {
41454150
intel_ddi_read_func_ctl_dp_sst(encoder, pipe_config, ddi_func_ctl);
4146-
} else if (ddi_mode == TRANS_DDI_MODE_SELECT_DP_MST ||
4147-
(ddi_mode == TRANS_DDI_MODE_SELECT_FDI_OR_128B132B && HAS_DP20(display))) {
4151+
} else if (ddi_mode == TRANS_DDI_MODE_SELECT_DP_MST) {
41484152
intel_ddi_read_func_ctl_dp_mst(encoder, pipe_config, ddi_func_ctl);
4153+
} else if (ddi_mode == TRANS_DDI_MODE_SELECT_FDI_OR_128B132B && HAS_DP20(display)) {
4154+
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
4155+
4156+
/*
4157+
* If this is true, we know we're being called from mst stream
4158+
* encoder's ->get_config().
4159+
*/
4160+
if (intel_dp->is_mst)
4161+
intel_ddi_read_func_ctl_dp_mst(encoder, pipe_config, ddi_func_ctl);
4162+
else
4163+
intel_ddi_read_func_ctl_dp_sst(encoder, pipe_config, ddi_func_ctl);
41494164
}
41504165
}
41514166

0 commit comments

Comments
 (0)