Skip to content

Commit 4166204

Browse files
leitaokuba-moo
authored andcommitted
net: tap: Remove generic .ndo_get_stats64
Commit 3e2f544 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao <[email protected]> Reviewed-by: Willem de Bruijn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 46f480e commit 4166204

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/tun.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1338,7 +1338,6 @@ static const struct net_device_ops tap_netdev_ops = {
13381338
.ndo_select_queue = tun_select_queue,
13391339
.ndo_features_check = passthru_features_check,
13401340
.ndo_set_rx_headroom = tun_set_headroom,
1341-
.ndo_get_stats64 = dev_get_tstats64,
13421341
.ndo_bpf = tun_xdp,
13431342
.ndo_xdp_xmit = tun_xdp_xmit,
13441343
.ndo_change_carrier = tun_net_change_carrier,

0 commit comments

Comments
 (0)