Skip to content

Commit 5513dc1

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: list sysctl data
Listing all the values linked to the MPTCP sysctl knobs was not exercised in MPTCP test suite. Let's do that to avoid any regressions, but also to have a kernel with a debug kconfig verifying more assumptions. For the moment, we are not interested by the output, only to avoid crashes and warnings. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 3deb12c commit 5513dc1

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

tools/testing/selftests/net/mptcp/mptcp_connect.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,15 @@ check_mptcp_disabled()
259259
mptcp_lib_ns_init disabled_ns
260260

261261
print_larger_title "New MPTCP socket can be blocked via sysctl"
262+
263+
# mainly to cover more code
264+
if ! ip netns exec ${disabled_ns} sysctl net.mptcp >/dev/null; then
265+
mptcp_lib_pr_fail "not able to list net.mptcp sysctl knobs"
266+
mptcp_lib_result_fail "not able to list net.mptcp sysctl knobs"
267+
ret=${KSFT_FAIL}
268+
return 1
269+
fi
270+
262271
# net.mptcp.enabled should be enabled by default
263272
if [ "$(ip netns exec ${disabled_ns} sysctl net.mptcp.enabled | awk '{ print $3 }')" -ne 1 ]; then
264273
mptcp_lib_pr_fail "net.mptcp.enabled sysctl is not 1 by default"

0 commit comments

Comments
 (0)