Skip to content

Commit 55a51ea

Browse files
geertuaxboe
authored andcommitted
block/mq-deadline: Move dd_queued() to fix defined but not used warning
If CONFIG_BLK_DEBUG_FS=n: block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function] 274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio) | ^~~~~~~~~ Fix this by moving dd_queued() just before the sole function that calls it. Fixes: 7b05bf7 ("Revert "block/mq-deadline: Prioritize high-priority requests"") Signed-off-by: Geert Uytterhoeven <[email protected]> Fixes: 38ba64d ("block/mq-deadline: Track I/O statistics") Reviewed-by: Bart Van Assche <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 4ac6d90 commit 55a51ea

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

block/mq-deadline.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,12 +270,6 @@ deadline_move_request(struct deadline_data *dd, struct dd_per_prio *per_prio,
270270
deadline_remove_request(rq->q, per_prio, rq);
271271
}
272272

273-
/* Number of requests queued for a given priority level. */
274-
static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
275-
{
276-
return dd_sum(dd, inserted, prio) - dd_sum(dd, completed, prio);
277-
}
278-
279273
/*
280274
* deadline_check_fifo returns 0 if there are no expired requests on the fifo,
281275
* 1 otherwise. Requires !list_empty(&dd->fifo_list[data_dir])
@@ -953,6 +947,12 @@ static int dd_async_depth_show(void *data, struct seq_file *m)
953947
return 0;
954948
}
955949

950+
/* Number of requests queued for a given priority level. */
951+
static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
952+
{
953+
return dd_sum(dd, inserted, prio) - dd_sum(dd, completed, prio);
954+
}
955+
956956
static int dd_queued_show(void *data, struct seq_file *m)
957957
{
958958
struct request_queue *q = data;

0 commit comments

Comments
 (0)