Skip to content

Commit 55f780c

Browse files
mohittahilianidavem330
authored andcommitted
net: sched: pie: fix commenting
Fix punctuation and logical mistakes in the comments. The logical mistake was that "dequeue_rate" is no longer the default way to calculate queuing delay and is not needed. The default way to calculate queue delay was changed in commit cec2975 ("net: sched: pie: enable timestamp based delay calculation"). Signed-off-by: Mohit P. Tahiliani <[email protected]> Signed-off-by: Leslie Monis <[email protected]> Signed-off-by: Gautam Ramakrishnan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b42a3d7 commit 55f780c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

net/sched/sch_pie.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,10 @@ static void pie_process_dequeue(struct Qdisc *sch, struct sk_buff *skb)
248248
q->vars.dq_count = 0;
249249
}
250250

251-
/* Calculate the average drain rate from this value. If queue length
252-
* has receded to a small value viz., <= QUEUE_THRESHOLD bytes,reset
251+
/* Calculate the average drain rate from this value. If queue length
252+
* has receded to a small value viz., <= QUEUE_THRESHOLD bytes, reset
253253
* the dq_count to -1 as we don't have enough packets to calculate the
254-
* drain rate anymore The following if block is entered only when we
254+
* drain rate anymore. The following if block is entered only when we
255255
* have a substantial queue built up (QUEUE_THRESHOLD bytes or more)
256256
* and we calculate the drain rate for the threshold here. dq_count is
257257
* in bytes, time difference in psched_time, hence rate is in
@@ -329,8 +329,8 @@ static void calculate_probability(struct Qdisc *sch)
329329
qdelay_old = q->vars.qdelay_old;
330330
}
331331

332-
/* If qdelay is zero and qlen is not, it means qlen is very small, less
333-
* than dequeue_rate, so we do not update probabilty in this round
332+
/* If qdelay is zero and qlen is not, it means qlen is very small,
333+
* so we do not update probabilty in this round.
334334
*/
335335
if (qdelay == 0 && qlen != 0)
336336
update_prob = false;

0 commit comments

Comments
 (0)