xen-netback: remove redundant assignment to err

Colin Ian King · davem330 · commit 587a7126779b · 2019-05-31T14:36:48.000-07:00
The variable err is assigned with the value -ENOMEM that is never
read and it is re-assigned a new value later on.  The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Acked-by: Wei Liu &lt;wei.liu2@citrix.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
@@ -633,7 +633,7 @@ int xenvif_connect_data(struct xenvif_queue *queue,
 			unsigned int rx_evtchn)
 {
 	struct task_struct *task;
-	int err = -ENOMEM;
+	int err;
 
 	BUG_ON(queue->tx_irq);
 	BUG_ON(queue->task);

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ int xenvif_connect_data(struct xenvif_queue *queue,`
`633`	`633`	`unsigned int rx_evtchn)`
`634`	`634`	`{`
`635`	`635`	`struct task_struct *task;`
`636`		`- int err = -ENOMEM;`
	`636`	`+ int err;`
`637`	`637`
`638`	`638`	`BUG_ON(queue->tx_irq);`
`639`	`639`	`BUG_ON(queue->task);`