Skip to content

Commit 58d89ee

Browse files
committed
Merge tag 'ata-6.10-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux
Pull ata fixes from Niklas Cassel: - Add a quirk for three different devices that have shown issues with LPM (link power management). These devices appear to not implement LPM properly, since we see command timeouts when enabling LPM. The quirk disables LPM for these problematic devices. (Me) - Do not apply the Intel PCS quirk on Alder Lake. The quirk is not needed and was originally added by mistake when LPM support was enabled for this AHCI controller. Enabling the quirk when not needed causes the the controller to not be able to detect the connected devices on some platforms. * tag 'ata-6.10-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux: ata: libata-core: Add ATA_HORKAGE_NOLPM for Apacer AS340 ata: libata-core: Add ATA_HORKAGE_NOLPM for AMD Radeon S3 SSD ata: libata-core: Add ATA_HORKAGE_NOLPM for Crucial CT240BX500SSD1 ata: ahci: Do not apply Intel PCS quirk on Intel Alder Lake
2 parents a693b9c + 3cb648c commit 58d89ee

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

drivers/ata/ahci.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,6 @@ static const struct pci_device_id ahci_pci_tbl[] = {
429429
{ PCI_VDEVICE(INTEL, 0x02d7), board_ahci_pcs_quirk }, /* Comet Lake PCH RAID */
430430
/* Elkhart Lake IDs 0x4b60 & 0x4b62 https://sata-io.org/product/8803 not tested yet */
431431
{ PCI_VDEVICE(INTEL, 0x4b63), board_ahci_pcs_quirk }, /* Elkhart Lake AHCI */
432-
{ PCI_VDEVICE(INTEL, 0x7ae2), board_ahci_pcs_quirk }, /* Alder Lake-P AHCI */
433432

434433
/* JMicron 360/1/3/5/6, match class to avoid IDE function */
435434
{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,

drivers/ata/libata-core.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4136,8 +4136,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
41364136
{ "PIONEER BD-RW BDR-207M", NULL, ATA_HORKAGE_NOLPM },
41374137
{ "PIONEER BD-RW BDR-205", NULL, ATA_HORKAGE_NOLPM },
41384138

4139-
/* Crucial BX100 SSD 500GB has broken LPM support */
4139+
/* Crucial devices with broken LPM support */
41404140
{ "CT500BX100SSD1", NULL, ATA_HORKAGE_NOLPM },
4141+
{ "CT240BX500SSD1", NULL, ATA_HORKAGE_NOLPM },
41414142

41424143
/* 512GB MX100 with MU01 firmware has both queued TRIM and LPM issues */
41434144
{ "Crucial_CT512MX100*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
@@ -4155,6 +4156,12 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
41554156
ATA_HORKAGE_ZERO_AFTER_TRIM |
41564157
ATA_HORKAGE_NOLPM },
41574158

4159+
/* AMD Radeon devices with broken LPM support */
4160+
{ "R3SL240G", NULL, ATA_HORKAGE_NOLPM },
4161+
4162+
/* Apacer models with LPM issues */
4163+
{ "Apacer AS340*", NULL, ATA_HORKAGE_NOLPM },
4164+
41584165
/* These specific Samsung models/firmware-revs do not handle LPM well */
41594166
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM },
41604167
{ "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM },

0 commit comments

Comments
 (0)