Skip to content

Commit 5a21bf5

Browse files
committed
Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue
Tony Nguyen says: ==================== 100GbE Intel Wired LAN Driver Updates 2021-12-14 This series contains updates to ice driver only. Haiyue adds support to query hardware for supported PTYPEs. Jeff changes PTYPE validation to utilize the capabilities queried from the hardware instead of maintaining a per DDP support list. Brett refactors promiscuous functions to provide common and clear interfaces to call for configuration. Wojciech modifies DDP package load to simplify determining the final state of the load. Tony removes the use of ice_status from the driver. This involves removing string conversion functions, converting variables and values to standard errors, and clean up. He also removes an unused define. Dan Carpenter removes unneeded casts. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 0b6f65c + f8a3bcc commit 5a21bf5

38 files changed

+2391
-2745
lines changed

drivers/net/ethernet/intel/ice/ice.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,6 @@ void ice_print_link_msg(struct ice_vsi *vsi, bool isup);
848848
int ice_plug_aux_dev(struct ice_pf *pf);
849849
void ice_unplug_aux_dev(struct ice_pf *pf);
850850
int ice_init_rdma(struct ice_pf *pf);
851-
const char *ice_stat_str(enum ice_status stat_err);
852851
const char *ice_aq_str(enum ice_aq_err aq_err);
853852
bool ice_is_wol_supported(struct ice_hw *hw);
854853
int

drivers/net/ethernet/intel/ice/ice_base.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring,
759759
struct ice_channel *ch = ring->ch;
760760
struct ice_pf *pf = vsi->back;
761761
struct ice_hw *hw = &pf->hw;
762-
enum ice_status status;
762+
int status;
763763
u16 pf_q;
764764
u8 tc;
765765

@@ -804,9 +804,9 @@ ice_vsi_cfg_txq(struct ice_vsi *vsi, struct ice_tx_ring *ring,
804804
ring->q_handle, 1, qg_buf, buf_len,
805805
NULL);
806806
if (status) {
807-
dev_err(ice_pf_to_dev(pf), "Failed to set LAN Tx queue context, error: %s\n",
808-
ice_stat_str(status));
809-
return -ENODEV;
807+
dev_err(ice_pf_to_dev(pf), "Failed to set LAN Tx queue context, error: %d\n",
808+
status);
809+
return status;
810810
}
811811

812812
/* Add Tx Queue TEID into the VSI Tx ring from the
@@ -929,7 +929,7 @@ ice_vsi_stop_tx_ring(struct ice_vsi *vsi, enum ice_disq_rst_src rst_src,
929929
struct ice_pf *pf = vsi->back;
930930
struct ice_q_vector *q_vector;
931931
struct ice_hw *hw = &pf->hw;
932-
enum ice_status status;
932+
int status;
933933
u32 val;
934934

935935
/* clear cause_ena bit for disabled queues */
@@ -953,18 +953,18 @@ ice_vsi_stop_tx_ring(struct ice_vsi *vsi, enum ice_disq_rst_src rst_src,
953953
rel_vmvf_num, NULL);
954954

955955
/* if the disable queue command was exercised during an
956-
* active reset flow, ICE_ERR_RESET_ONGOING is returned.
956+
* active reset flow, -EBUSY is returned.
957957
* This is not an error as the reset operation disables
958958
* queues at the hardware level anyway.
959959
*/
960-
if (status == ICE_ERR_RESET_ONGOING) {
960+
if (status == -EBUSY) {
961961
dev_dbg(ice_pf_to_dev(vsi->back), "Reset in progress. LAN Tx queues already disabled\n");
962-
} else if (status == ICE_ERR_DOES_NOT_EXIST) {
962+
} else if (status == -ENOENT) {
963963
dev_dbg(ice_pf_to_dev(vsi->back), "LAN Tx queues do not exist, nothing to disable\n");
964964
} else if (status) {
965-
dev_dbg(ice_pf_to_dev(vsi->back), "Failed to disable LAN Tx queues, error: %s\n",
966-
ice_stat_str(status));
967-
return -ENODEV;
965+
dev_dbg(ice_pf_to_dev(vsi->back), "Failed to disable LAN Tx queues, error: %d\n",
966+
status);
967+
return status;
968968
}
969969

970970
return 0;

0 commit comments

Comments
 (0)