Skip to content

Commit 5a7c5f7

Browse files
vladimirolteankuba-moo
authored andcommitted
selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer
As discussed here with Ido Schimmel: https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/ the default conform-exceed action is "reclassify", for a reason we don't really understand. The point is that hardware can't offload that police action, so not specifying "conform-exceed" was always wrong, even though the command used to work in hardware (but not in software) until the kernel started adding validation for it. Fix the command used by the selftest by making the policer drop on exceed, and pass the packet to the next action (goto) on conform. Fixes: 8cd6b02 ("selftests: ocelot: add some example VCAP IS1, IS2 and ES0 tc offloads") Signed-off-by: Vladimir Oltean <[email protected]> Reviewed-by: Ido Schimmel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent ef56248 commit 5a7c5f7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ setup_prepare()
190190

191191
tc filter add dev $eth0 ingress chain $(IS2 0 0) pref 1 \
192192
protocol ipv4 flower skip_sw ip_proto udp dst_port 5201 \
193-
action police rate 50mbit burst 64k \
193+
action police rate 50mbit burst 64k conform-exceed drop/pipe \
194194
action goto chain $(IS2 1 0)
195195
}
196196

0 commit comments

Comments
 (0)