Skip to content

Commit 60f83c8

Browse files
Thanneeru Srinivasuludavem330
authored andcommitted
net: thunderx: Fix for crash while BGX teardown
Cortina phy does not have kernel driver and we don't attach device with phy layer for intefaces like XFI, XLAUI etc, Hence check for interface type before calling disconnect. Signed-off-by: Thanneeru Srinivasulu <[email protected]> Signed-off-by: Aleksey Makarov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4adf435 commit 60f83c8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/cavium/thunder/thunder_bgx.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,10 @@ static void bgx_lmac_disable(struct bgx *bgx, u8 lmacid)
673673
bgx_reg_write(bgx, lmacid, BGX_CMRX_CFG, cmrx_cfg);
674674
bgx_flush_dmac_addrs(bgx, lmacid);
675675

676-
if (lmac->phydev)
676+
if ((bgx->lmac_type != BGX_MODE_XFI) &&
677+
(bgx->lmac_type != BGX_MODE_XLAUI) &&
678+
(bgx->lmac_type != BGX_MODE_40G_KR) &&
679+
(bgx->lmac_type != BGX_MODE_10G_KR) && lmac->phydev)
677680
phy_disconnect(lmac->phydev);
678681

679682
lmac->phydev = NULL;

0 commit comments

Comments
 (0)