Skip to content

Commit 6674586

Browse files
committed
Merge tag 'char-misc-5.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc driver fixes from Greg KH: "Here are some small char/misc driver fixes for 5.14-rc5. They resolve a few regressions that people reported: - acrn driver fix - fpga driver fix - interconnect tiny driver fixes All have been in linux-next for a while with no reported issues" * tag 'char-misc-5.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: interconnect: Fix undersized devress_alloc allocation interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate interconnect: qcom: icc-rpmh: Ensure floor BW is enforced for all nodes fpga: dfl: fme: Fix cpu hotplug issue in performance reporting virt: acrn: Do hcall_destroy_vm() before resource release interconnect: Always call pre_aggregate before aggregate interconnect: Zero initial BW after sync-state
2 parents 289ef7b + 6bfc527 commit 6674586

File tree

4 files changed

+28
-21
lines changed

4 files changed

+28
-21
lines changed

drivers/fpga/dfl-fme-perf.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
953953
return 0;
954954

955955
priv->cpu = target;
956+
perf_pmu_migrate_context(&priv->pmu, cpu, target);
957+
956958
return 0;
957959
}
958960

drivers/interconnect/core.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ struct icc_path *devm_of_icc_get(struct device *dev, const char *name)
403403
{
404404
struct icc_path **ptr, *path;
405405

406-
ptr = devres_alloc(devm_icc_release, sizeof(**ptr), GFP_KERNEL);
406+
ptr = devres_alloc(devm_icc_release, sizeof(*ptr), GFP_KERNEL);
407407
if (!ptr)
408408
return ERR_PTR(-ENOMEM);
409409

@@ -973,9 +973,14 @@ void icc_node_add(struct icc_node *node, struct icc_provider *provider)
973973
}
974974
node->avg_bw = node->init_avg;
975975
node->peak_bw = node->init_peak;
976+
977+
if (provider->pre_aggregate)
978+
provider->pre_aggregate(node);
979+
976980
if (provider->aggregate)
977981
provider->aggregate(node, 0, node->init_avg, node->init_peak,
978982
&node->avg_bw, &node->peak_bw);
983+
979984
provider->set(node, node);
980985
node->avg_bw = 0;
981986
node->peak_bw = 0;
@@ -1106,6 +1111,8 @@ void icc_sync_state(struct device *dev)
11061111
dev_dbg(p->dev, "interconnect provider is in synced state\n");
11071112
list_for_each_entry(n, &p->nodes, node_list) {
11081113
if (n->init_avg || n->init_peak) {
1114+
n->init_avg = 0;
1115+
n->init_peak = 0;
11091116
aggregate_requests(n);
11101117
p->set(n, n);
11111118
}

drivers/interconnect/qcom/icc-rpmh.c

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,18 @@ void qcom_icc_pre_aggregate(struct icc_node *node)
2020
{
2121
size_t i;
2222
struct qcom_icc_node *qn;
23+
struct qcom_icc_provider *qp;
2324

2425
qn = node->data;
26+
qp = to_qcom_provider(node->provider);
2527

2628
for (i = 0; i < QCOM_ICC_NUM_BUCKETS; i++) {
2729
qn->sum_avg[i] = 0;
2830
qn->max_peak[i] = 0;
2931
}
32+
33+
for (i = 0; i < qn->num_bcms; i++)
34+
qcom_icc_bcm_voter_add(qp->voter, qn->bcms[i]);
3035
}
3136
EXPORT_SYMBOL_GPL(qcom_icc_pre_aggregate);
3237

@@ -44,10 +49,8 @@ int qcom_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
4449
{
4550
size_t i;
4651
struct qcom_icc_node *qn;
47-
struct qcom_icc_provider *qp;
4852

4953
qn = node->data;
50-
qp = to_qcom_provider(node->provider);
5154

5255
if (!tag)
5356
tag = QCOM_ICC_TAG_ALWAYS;
@@ -57,14 +60,16 @@ int qcom_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
5760
qn->sum_avg[i] += avg_bw;
5861
qn->max_peak[i] = max_t(u32, qn->max_peak[i], peak_bw);
5962
}
63+
64+
if (node->init_avg || node->init_peak) {
65+
qn->sum_avg[i] = max_t(u64, qn->sum_avg[i], node->init_avg);
66+
qn->max_peak[i] = max_t(u64, qn->max_peak[i], node->init_peak);
67+
}
6068
}
6169

6270
*agg_avg += avg_bw;
6371
*agg_peak = max_t(u32, *agg_peak, peak_bw);
6472

65-
for (i = 0; i < qn->num_bcms; i++)
66-
qcom_icc_bcm_voter_add(qp->voter, qn->bcms[i]);
67-
6873
return 0;
6974
}
7075
EXPORT_SYMBOL_GPL(qcom_icc_aggregate);
@@ -79,7 +84,6 @@ EXPORT_SYMBOL_GPL(qcom_icc_aggregate);
7984
int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
8085
{
8186
struct qcom_icc_provider *qp;
82-
struct qcom_icc_node *qn;
8387
struct icc_node *node;
8488

8589
if (!src)
@@ -88,12 +92,6 @@ int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
8892
node = src;
8993

9094
qp = to_qcom_provider(node->provider);
91-
qn = node->data;
92-
93-
qn->sum_avg[QCOM_ICC_BUCKET_AMC] = max_t(u64, qn->sum_avg[QCOM_ICC_BUCKET_AMC],
94-
node->avg_bw);
95-
qn->max_peak[QCOM_ICC_BUCKET_AMC] = max_t(u64, qn->max_peak[QCOM_ICC_BUCKET_AMC],
96-
node->peak_bw);
9795

9896
qcom_icc_bcm_voter_commit(qp->voter);
9997

drivers/virt/acrn/vm.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,14 @@ int acrn_vm_destroy(struct acrn_vm *vm)
6464
test_and_set_bit(ACRN_VM_FLAG_DESTROYED, &vm->flags))
6565
return 0;
6666

67+
ret = hcall_destroy_vm(vm->vmid);
68+
if (ret < 0) {
69+
dev_err(acrn_dev.this_device,
70+
"Failed to destroy VM %u\n", vm->vmid);
71+
clear_bit(ACRN_VM_FLAG_DESTROYED, &vm->flags);
72+
return ret;
73+
}
74+
6775
/* Remove from global VM list */
6876
write_lock_bh(&acrn_vm_list_lock);
6977
list_del_init(&vm->list);
@@ -78,14 +86,6 @@ int acrn_vm_destroy(struct acrn_vm *vm)
7886
vm->monitor_page = NULL;
7987
}
8088

81-
ret = hcall_destroy_vm(vm->vmid);
82-
if (ret < 0) {
83-
dev_err(acrn_dev.this_device,
84-
"Failed to destroy VM %u\n", vm->vmid);
85-
clear_bit(ACRN_VM_FLAG_DESTROYED, &vm->flags);
86-
return ret;
87-
}
88-
8989
acrn_vm_all_ram_unmap(vm);
9090

9191
dev_dbg(acrn_dev.this_device, "VM %u destroyed.\n", vm->vmid);

0 commit comments

Comments
 (0)