Skip to content

Commit 68481a7

Browse files
Krishna Reddystorulf
authored andcommitted
mmc: tegra: Mark 64 bit dma broken on Tegra186
SDHCI controllers on Tegra186 support 40 bit addressing. IOVA addresses are 48-bit wide on Tegra186. SDHCI host common code sets dma mask as either 32-bit or 64-bit. To avoid access issues when SMMU is enabled, disable 64-bit dma. Signed-off-by: Krishna Reddy <[email protected]> Tested-by: Thierry Reding <[email protected]> Acked-by: Thierry Reding <[email protected]> Acked-by: Adrian Hunter <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent faf73fa commit 68481a7

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

drivers/mmc/host/sdhci-tegra.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,15 @@ static const struct sdhci_pltfm_data sdhci_tegra186_pdata = {
422422
SDHCI_QUIRK_NO_HISPD_BIT |
423423
SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC |
424424
SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
425-
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
425+
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN |
426+
/* SDHCI controllers on Tegra186 support 40-bit addressing.
427+
* IOVA addresses are 48-bit wide on Tegra186.
428+
* With 64-bit dma mask used for SDHCI, accesses can
429+
* be broken. Disable 64-bit dma, which would fall back
430+
* to 32-bit dma mask. Ideally 40-bit dma mask would work,
431+
* But it is not supported as of now.
432+
*/
433+
SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
426434
.ops = &tegra114_sdhci_ops,
427435
};
428436

0 commit comments

Comments
 (0)