Skip to content

Commit 6eb0824

Browse files
Javier Gonzálezaxboe
authored andcommitted
lightnvm: convert sprintf into strlcpy
Convert sprintf calls to strlcpy in order to make possible buffer overflow more obvious. Signed-off-by: Javier González <[email protected]> Signed-off-by: Matias Bjørling <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent d788c59 commit 6eb0824

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/lightnvm/core.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
273273
goto err_disk;
274274
blk_queue_make_request(tqueue, tt->make_rq);
275275

276-
sprintf(tdisk->disk_name, "%s", create->tgtname);
276+
strlcpy(tdisk->disk_name, create->tgtname, sizeof(tdisk->disk_name));
277277
tdisk->flags = GENHD_FL_EXT_DEVT;
278278
tdisk->major = 0;
279279
tdisk->first_minor = 0;
@@ -1198,13 +1198,13 @@ static long nvm_ioctl_get_devices(struct file *file, void __user *arg)
11981198
list_for_each_entry(dev, &nvm_devices, devices) {
11991199
struct nvm_ioctl_device_info *info = &devices->info[i];
12001200

1201-
sprintf(info->devname, "%s", dev->name);
1201+
strlcpy(info->devname, dev->name, sizeof(info->devname));
12021202

12031203
/* kept for compatibility */
12041204
info->bmversion[0] = 1;
12051205
info->bmversion[1] = 0;
12061206
info->bmversion[2] = 0;
1207-
sprintf(info->bmname, "%s", "gennvm");
1207+
strlcpy(info->bmname, "gennvm", sizeof(info->bmname));
12081208
i++;
12091209

12101210
if (i > 31) {

0 commit comments

Comments
 (0)