Skip to content

Commit 728e74a

Browse files
Uwe Kleine-Königgregkh
authored andcommitted
serial: imx: fix comment about UCR2_SRST and its handling for shadowing
Initially when register shadowing was introduced (commit 3a0ab62 ("serial: imx: implement shadow registers for UCRx and UFCR")) the logic to handle UCR2_SRST was wrong but documented consistently. Later the handling was fixed, but the comment was not. This change makes up leeway for the latter. Fixes: 0aa821d ("serial: imx: fix cached UCR2 read on software reset") Signed-off-by: Uwe Kleine-König <[email protected]> Reviewed-by: Stefan Agner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7daf201 commit 728e74a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/tty/serial/imx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
314314
/*
315315
* UCR2_SRST is the only bit in the cached registers that might
316316
* differ from the value that was last written. As it only
317-
* clears after being set, reread conditionally.
317+
* automatically becomes one after being cleared, reread
318+
* conditionally.
318319
*/
319320
if (!(sport->ucr2 & UCR2_SRST))
320321
sport->ucr2 = readl(sport->port.membase + offset);

0 commit comments

Comments
 (0)