Skip to content

Commit 7460b47

Browse files
x-y-zakpm00
authored andcommitted
mm/truncate: use folio_split() in truncate operation
Instead of splitting the large folio uniformly during truncation, try to use buddy allocator like folio_split() at the start and the end of a truncation range to minimize the number of resulting folios if it is supported. try_folio_split() is introduced to use folio_split() if supported and it falls back to uniform split otherwise. For example, to truncate a order-4 folio [0, 1, 2, 3, 4, 5, ..., 15] between [3, 10] (inclusive), folio_split() splits the folio at 3 to [0,1], [2], [3], [4..7], [8..15] and [3], [4..7] can be dropped and [8..15] is kept with zeros in [8..10], then another folio_split() is done at 10, so [8..10] can be dropped. One possible optimization is to make folio_split() to split a folio based on a given range, like [3..10] above. But that complicates folio_split(), so it will be investigated when necessary. Link: https://lkml.kernel.org/r/[email protected] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Zi Yan <[email protected]> Cc: Baolin Wang <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: Hugh Dickins <[email protected]> Cc: John Hubbard <[email protected]> Cc: Kefeng Wang <[email protected]> Cc: Kirill A. Shuemov <[email protected]> Cc: Matthew Wilcox <[email protected]> Cc: Miaohe Lin <[email protected]> Cc: Ryan Roberts <[email protected]> Cc: Yang Shi <[email protected]> Cc: Yu Zhao <[email protected]> Cc: Kairui Song <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 4b94c18 commit 7460b47

File tree

3 files changed

+75
-4
lines changed

3 files changed

+75
-4
lines changed

include/linux/huge_mm.h

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,36 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
345345
unsigned int new_order);
346346
int min_order_for_split(struct folio *folio);
347347
int split_folio_to_list(struct folio *folio, struct list_head *list);
348+
bool uniform_split_supported(struct folio *folio, unsigned int new_order,
349+
bool warns);
350+
bool non_uniform_split_supported(struct folio *folio, unsigned int new_order,
351+
bool warns);
352+
int folio_split(struct folio *folio, unsigned int new_order, struct page *page,
353+
struct list_head *list);
354+
/*
355+
* try_folio_split - try to split a @folio at @page using non uniform split.
356+
* @folio: folio to be split
357+
* @page: split to order-0 at the given page
358+
* @list: store the after-split folios
359+
*
360+
* Try to split a @folio at @page using non uniform split to order-0, if
361+
* non uniform split is not supported, fall back to uniform split.
362+
*
363+
* Return: 0: split is successful, otherwise split failed.
364+
*/
365+
static inline int try_folio_split(struct folio *folio, struct page *page,
366+
struct list_head *list)
367+
{
368+
int ret = min_order_for_split(folio);
369+
370+
if (ret < 0)
371+
return ret;
372+
373+
if (!non_uniform_split_supported(folio, 0, false))
374+
return split_huge_page_to_list_to_order(&folio->page, list,
375+
ret);
376+
return folio_split(folio, ret, page, list);
377+
}
348378
static inline int split_huge_page(struct page *page)
349379
{
350380
struct folio *folio = page_folio(page);
@@ -537,6 +567,12 @@ static inline int split_folio_to_list(struct folio *folio, struct list_head *lis
537567
return 0;
538568
}
539569

570+
static inline int try_folio_split(struct folio *folio, struct page *page,
571+
struct list_head *list)
572+
{
573+
return 0;
574+
}
575+
540576
static inline void deferred_split_folio(struct folio *folio, bool partially_mapped) {}
541577
#define split_huge_pmd(__vma, __pmd, __address) \
542578
do { } while (0)

mm/huge_memory.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3654,7 +3654,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
36543654
return ret;
36553655
}
36563656

3657-
static bool non_uniform_split_supported(struct folio *folio, unsigned int new_order,
3657+
bool non_uniform_split_supported(struct folio *folio, unsigned int new_order,
36583658
bool warns)
36593659
{
36603660
if (folio_test_anon(folio)) {
@@ -3686,7 +3686,7 @@ static bool non_uniform_split_supported(struct folio *folio, unsigned int new_or
36863686
}
36873687

36883688
/* See comments in non_uniform_split_supported() */
3689-
static bool uniform_split_supported(struct folio *folio, unsigned int new_order,
3689+
bool uniform_split_supported(struct folio *folio, unsigned int new_order,
36903690
bool warns)
36913691
{
36923692
if (folio_test_anon(folio)) {
@@ -4005,7 +4005,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
40054005
*
40064006
* After split, folio is left locked for caller.
40074007
*/
4008-
static int folio_split(struct folio *folio, unsigned int new_order,
4008+
int folio_split(struct folio *folio, unsigned int new_order,
40094009
struct page *split_at, struct list_head *list)
40104010
{
40114011
return __folio_split(folio, new_order, split_at, &folio->page, list,

mm/truncate.c

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ bool truncate_inode_partial_folio(struct folio *folio, loff_t start, loff_t end)
192192
{
193193
loff_t pos = folio_pos(folio);
194194
unsigned int offset, length;
195+
struct page *split_at, *split_at2;
195196

196197
if (pos < start)
197198
offset = start - pos;
@@ -221,8 +222,42 @@ bool truncate_inode_partial_folio(struct folio *folio, loff_t start, loff_t end)
221222
folio_invalidate(folio, offset, length);
222223
if (!folio_test_large(folio))
223224
return true;
224-
if (split_folio(folio) == 0)
225+
226+
split_at = folio_page(folio, PAGE_ALIGN_DOWN(offset) / PAGE_SIZE);
227+
split_at2 = folio_page(folio,
228+
PAGE_ALIGN_DOWN(offset + length) / PAGE_SIZE);
229+
230+
if (!try_folio_split(folio, split_at, NULL)) {
231+
/*
232+
* try to split at offset + length to make sure folios within
233+
* the range can be dropped, especially to avoid memory waste
234+
* for shmem truncate
235+
*/
236+
struct folio *folio2 = page_folio(split_at2);
237+
238+
if (!folio_try_get(folio2))
239+
goto no_split;
240+
241+
if (!folio_test_large(folio2))
242+
goto out;
243+
244+
if (!folio_trylock(folio2))
245+
goto out;
246+
247+
/*
248+
* make sure folio2 is large and does not change its mapping.
249+
* Its split result does not matter here.
250+
*/
251+
if (folio_test_large(folio2) &&
252+
folio2->mapping == folio->mapping)
253+
try_folio_split(folio2, split_at2, NULL);
254+
255+
folio_unlock(folio2);
256+
out:
257+
folio_put(folio2);
258+
no_split:
225259
return true;
260+
}
226261
if (folio_test_dirty(folio))
227262
return false;
228263
truncate_inode_folio(folio->mapping, folio);

0 commit comments

Comments
 (0)